Siebrand has uploaded a new change for review. https://gerrit.wikimedia.org/r/102660
Change subject: Add TODOs for incorrectly referenced class properties ...................................................................... Add TODOs for incorrectly referenced class properties Change-Id: If3d4bbe9d800a3f44b24f223fb88ca1c48d0ffb5 --- M tests/phpunit/MessageIndexTest.php M tests/phpunit/MockWikiMessageGroup.php 2 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/60/102660/1 diff --git a/tests/phpunit/MessageIndexTest.php b/tests/phpunit/MessageIndexTest.php index 5079f85..8d5957e 100644 --- a/tests/phpunit/MessageIndexTest.php +++ b/tests/phpunit/MessageIndexTest.php @@ -36,12 +36,14 @@ public function testMessageIndexImplementation( $mi ) { $data = self::getTestData(); /** @var MessageIndex $mi */ + // @todo Member has protected access $mi->store( $data ); $tests = array_rand( $data, 10 ); foreach ( $tests as $key ) { $this->assertSame( $data[$key], + // @todo Member has protected access $mi->get( $key ), "Values are preserved for random key $key" ); @@ -53,6 +55,7 @@ foreach ( $tests as $key ) { $this->assertSame( $data[$key], + // @todo Member has protected access $mi->get( $key ), "Values are preserved after retrieve for random key $key" ); diff --git a/tests/phpunit/MockWikiMessageGroup.php b/tests/phpunit/MockWikiMessageGroup.php index 2bce606..ca185ed 100644 --- a/tests/phpunit/MockWikiMessageGroup.php +++ b/tests/phpunit/MockWikiMessageGroup.php @@ -14,10 +14,12 @@ public function __construct( $id, array $messages ) { parent::__construct( $id, 'unused' ); $this->id = $id; + // @todo Member has private access $this->messages = $messages; } public function getDefinitions() { + // @todo Member has private access return $this->messages; } } -- To view, visit https://gerrit.wikimedia.org/r/102660 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If3d4bbe9d800a3f44b24f223fb88ca1c48d0ffb5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Siebrand <siebr...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits