Aaron Schulz has submitted this change and it was merged. Change subject: Don't exit too quickly when reporting an exception. ......................................................................
Don't exit too quickly when reporting an exception. MWExceptionHander::handle() already exist at the end of its task, so there's no need to have other die() calls. There were some problems with that: - wfLogProfilingData() was only called after reporting some exception - MWExceptionHandler::report() was not consistent between web and command-linerequests - MWException::reportHTML() was also not consistent when using the OutputPage object or not Also removed MWExceptionHander::escapeEchoAndDie() since it's not needed anymore. Change-Id: Ibb679c425ef0271a65f623c7b8541ec9bec70eb0 --- M includes/Exception.php 1 file changed, 2 insertions(+), 14 deletions(-) Approvals: Aaron Schulz: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/23236 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb679c425ef0271a65f623c7b8541ec9bec70eb0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: IAlex <ialex.w...@gmail.com> Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
