Alex Monk has submitted this change and it was merged. Change subject: Remove invalid wikitext [[|New reply]] ......................................................................
Remove invalid wikitext [[|New reply]] A bit hackish so feedback is welcome. If Title doesn't exist we show a new message 'New reply created (deleted)'. Bug: 47006 Change-Id: I4ba3bf1c10860d4fe331f894f4b3a5de1ee52613 --- M classes/ThreadHistoryPager.php M i18n/Lqt.i18n.php 2 files changed, 7 insertions(+), 0 deletions(-) Approvals: Alex Monk: Verified; Looks good to me, approved diff --git a/classes/ThreadHistoryPager.php b/classes/ThreadHistoryPager.php index 2dd72ce..572a8bd 100644 --- a/classes/ThreadHistoryPager.php +++ b/classes/ThreadHistoryPager.php @@ -129,6 +129,11 @@ $args[] = ''; } break; + case Threads::CHANGE_REPLY_CREATED: + if ( !$changeObject || !$changeObject->title() ) { + $msg = wfMessage( 'lqt_hist_reply_created_deleted' )->parse(); + } + break; } $content = wfMsgReplaceArgs( $msg, $args ); diff --git a/i18n/Lqt.i18n.php b/i18n/Lqt.i18n.php index 202f979..4c87ac8 100644 --- a/i18n/Lqt.i18n.php +++ b/i18n/Lqt.i18n.php @@ -40,6 +40,7 @@ 'lqt_hist_comment_edited' => 'Comment text [$2 edited]', 'lqt_hist_summary_changed' => 'Summary changed', 'lqt_hist_reply_created' => '[[$1|New reply]] created', + 'lqt_hist_reply_created_deleted' => 'New reply created (since deleted)', 'lqt_hist_thread_created' => 'New thread created', 'lqt_hist_deleted' => 'Deleted', 'lqt_hist_undeleted' => 'Undeleted', @@ -396,6 +397,7 @@ Parameters: * $1 is the text for a wiki link to the new reply", 'lqt_hist_thread_created' => "Summary for 'activity' in thread history, see [{{canonicalurl:Thread:Support/Payflowpro_gateway-select-dollar-amount|lqt_method=thread_history}} example]", + 'lqt_hist_reply_created_deleted' => 'Same as {{msg-mw|lqt_hist_reply_created}} but when the reply has been deleted', 'lqt_hist_deleted' => '{{Identical|Deleted}}', 'lqt_hist_moved_talkpage' => '{{Identical|Move}}', 'lqt_hist_listing_subtitle' => "Subtitle for 'thread history' page, see [{{canonicalurl:Thread:Support/Payflowpro_gateway-select-dollar-amount|lqt_method=thread_history}} example]", -- To view, visit https://gerrit.wikimedia.org/r/58096 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ba3bf1c10860d4fe331f894f4b3a5de1ee52613 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/LiquidThreads Gerrit-Branch: master Gerrit-Owner: Nischayn22 <nischay...@gmail.com> Gerrit-Reviewer: Alex Monk <kren...@gmail.com> Gerrit-Reviewer: Nischayn22 <nischay...@gmail.com> Gerrit-Reviewer: Reedy <re...@wikimedia.org> Gerrit-Reviewer: Siebrand <siebr...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits