Daniel Werner has submitted this change and it was merged.

Change subject: (Bug 38843) Refine behavior of wbsetitem
......................................................................


(Bug 38843) Refine behavior of wbsetitem

There are a few remaining issues with wbsetitem, the most important
is that the input format should support what we call "the long format"
which is as close as possible to the output json format.

Refer to the documentation for wbsetitem for a complete description.

Patchset 3: Cleanup of duplicate code

Patchset 4: Rebase, fixed exceptions, uncommented a test.

Change-Id: I8d833861f7a4540b0c03a11b936be6bd9f6c0219
---
M repo/includes/api/ApiSetItem.php
M repo/tests/phpunit/includes/api/ApiBotEditTest.php
M repo/tests/phpunit/includes/api/ApiGetItemsTest.php
M repo/tests/phpunit/includes/api/ApiModifyItemBase.php
M repo/tests/phpunit/includes/api/ApiPermissionsTest.php
M repo/tests/phpunit/includes/api/ApiSetItemTest.php
M repo/tests/phpunit/includes/api/ApiSetSiteLinkTest.php
7 files changed, 299 insertions(+), 152 deletions(-)

Approvals:
  Daniel Werner: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/22487
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8d833861f7a4540b0c03a11b936be6bd9f6c0219
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: John Erling Blad <john.b...@wikimedia.de>
Gerrit-Reviewer: Daniel Werner <daniel.wer...@wikimedia.de>
Gerrit-Reviewer: John Erling Blad <john.b...@wikimedia.de>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to