jenkins-bot has submitted this change and it was merged.
Change subject: Remove hints to fixed bug 54044
......................................................................
Remove hints to fixed bug 54044
Change-Id: I119a2ec4114fd7939ef2d74e614b4a8ff8e257ac
---
M includes/Title.php
M tests/phpunit/includes/TitleTest.php
M tests/qunit/suites/resources/mediawiki/mediawiki.Title.test.js
3 files changed, 0 insertions(+), 3 deletions(-)
Approvals:
Parent5446: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Title.php b/includes/Title.php
index d89a821..5ab9e94 100644
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -3312,7 +3312,6 @@
# Can't make a link to a namespace alone... "empty" local links
can only be
# self-links with a fragment identifier.
- # TODO: Why do we exclude NS_MAIN (bug 54044)
if ( $dbkey == '' && $this->mInterwiki == '' &&
$this->mNamespace != NS_MAIN ) {
return false;
}
diff --git a/tests/phpunit/includes/TitleTest.php
b/tests/phpunit/includes/TitleTest.php
index 58f0146..54e6199 100644
--- a/tests/phpunit/includes/TitleTest.php
+++ b/tests/phpunit/includes/TitleTest.php
@@ -104,7 +104,6 @@
'A ~~~~~ Timestamp',
str_repeat( 'x', 256 ),
// Namespace prefix without actual title
- // ':', // bug 54044
'Talk:',
'Category: ',
'Category: #bar'
diff --git a/tests/qunit/suites/resources/mediawiki/mediawiki.Title.test.js
b/tests/qunit/suites/resources/mediawiki/mediawiki.Title.test.js
index 4083564..aeefd64 100644
--- a/tests/qunit/suites/resources/mediawiki/mediawiki.Title.test.js
+++ b/tests/qunit/suites/resources/mediawiki/mediawiki.Title.test.js
@@ -121,7 +121,6 @@
// purposes it is part of the title
repeat( 'x', 252 ) + '.json',
// Namespace prefix without actual title
- // ':', // bug 54044
'Talk:',
'Category: ',
'Category: #bar'
--
To view, visit https://gerrit.wikimedia.org/r/104019
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I119a2ec4114fd7939ef2d74e614b4a8ff8e257ac
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Parent5446 <tylerro...@gmail.com>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
