jenkins-bot has submitted this change and it was merged.

Change subject: wfRunHooks() return value no longer implies whether variable 
value was found
......................................................................


wfRunHooks() return value no longer implies whether variable value was found

Bug: 12837
Change-Id: I459923deee4fa294f78f277620f229fc2a84d266
---
M includes/parser/Parser.php
1 file changed, 2 insertions(+), 5 deletions(-)

Approvals:
  Siebrand: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/parser/Parser.php b/includes/parser/Parser.php
index 9be75ae..31638ce 100644
--- a/includes/parser/Parser.php
+++ b/includes/parser/Parser.php
@@ -3034,11 +3034,8 @@
                                return $wgLanguageCode;
                        default:
                                $ret = null;
-                               if ( wfRunHooks( 
'ParserGetVariableValueSwitch', array( &$this, &$this->mVarCache, &$index, 
&$ret, &$frame ) ) ) {
-                                       return $ret;
-                               } else {
-                                       return null;
-                               }
+                               wfRunHooks( 'ParserGetVariableValueSwitch', 
array( &$this, &$this->mVarCache, &$index, &$ret, &$frame ) );
+                               return $ret;
                }
 
                if ( $index ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/104203
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I459923deee4fa294f78f277620f229fc2a84d266
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Vishnunk90 <mails2vi...@gmail.com>
Gerrit-Reviewer: Brian Wolff <bawolff...@gmail.com>
Gerrit-Reviewer: Cscott <canan...@wikimedia.org>
Gerrit-Reviewer: Daniel Friesen <dan...@nadir-seen-fire.com>
Gerrit-Reviewer: Daniel Werner <daniel.a.r.wer...@gmail.com>
Gerrit-Reviewer: MarkAHershberger <mhershber...@wikimedia.org>
Gerrit-Reviewer: Nemo bis <federicol...@tiscali.it>
Gerrit-Reviewer: Parent5446 <tylerro...@gmail.com>
Gerrit-Reviewer: Siebrand <siebr...@wikimedia.org>
Gerrit-Reviewer: Sumanah <suma...@wikimedia.org>
Gerrit-Reviewer: Vishnunk90 <mails2vi...@gmail.com>
Gerrit-Reviewer: au <audr...@audreyt.org>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to