Siebrand has uploaded a new change for review. https://gerrit.wikimedia.org/r/104728
Change subject: Fix some JSHint issues ...................................................................... Fix some JSHint issues Change-Id: I46ae3ce2f39b35af6d75a94b5132eea0e6672064 --- M modules/ext.codeEditor.geshi.js M modules/jquery.codeEditor.js 2 files changed, 11 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeEditor refs/changes/28/104728/1 diff --git a/modules/ext.codeEditor.geshi.js b/modules/ext.codeEditor.geshi.js index 34d6bc6..cc8681d 100644 --- a/modules/ext.codeEditor.geshi.js +++ b/modules/ext.codeEditor.geshi.js @@ -13,7 +13,7 @@ .attr('href', '#') .attr('title', 'Edit this code section') .click(function(event) { - openEditor($div) + openEditor($div); event.preventDefault(); }); var $edit = $('<span>') @@ -97,7 +97,7 @@ type: 'POST', success: function(data, xhr) { var $html = $(data.parse.text['*']); - $div.replaceWith($html) + $div.replaceWith($html); setupEditor($html); @@ -120,7 +120,7 @@ .append($controls) .append($container); $xcontainer.width($main.width()) - .height($main.height() * 1.1 + 64 + 32); + .height($main.height() * 1.1 + 64 + 32); $div.css('display', 'none'); $xcontainer.insertAfter($div); diff --git a/modules/jquery.codeEditor.js b/modules/jquery.codeEditor.js index 2c320d9..a467833 100644 --- a/modules/jquery.codeEditor.js +++ b/modules/jquery.codeEditor.js @@ -66,7 +66,7 @@ } ); var cookieEnabled = $.cookie('wikiEditor-' + context.instance + '-codeEditor-enabled'); -context.codeEditorActive = (cookieEnabled != '0'); +context.codeEditorActive = (cookieEnabled !== '0'); /** * Internally used functions @@ -104,7 +104,7 @@ } else { context.fn.disableCodeEditor(); } - } + }; context.api.addToToolbar( context, { 'section': 'main', 'group': 'format', @@ -132,7 +132,7 @@ 'setupCodeEditor': function() { var box = context.$textarea; - var lang = mw.config.get("wgCodeEditorCurrentLanguage") + var lang = mw.config.get("wgCodeEditorCurrentLanguage"); if (lang) { // Ace doesn't like replacing a textarea directly. // We'll stub this out to sit on top of it... @@ -142,7 +142,7 @@ box.css('display', 'none'); container.width(box.width()) - .height(box.height()); + .height(box.height()); editdiv.text(box.val()); context.codeEditor = ace.edit(editdiv[0]); @@ -283,7 +283,7 @@ } else { throw new Error('CodeEditor: no original function to call for ' + name); } - } + }; } else { base[name] = func; } @@ -388,7 +388,7 @@ } col = offset - pos; return {row: row, column: col}; - } + }; var start = offsetToPos( options.start ), end = offsetToPos( options.end ); @@ -425,4 +425,5 @@ context.fn.setupCodeEditor(); } -} } )( jQuery ); +}; +} )( jQuery ); -- To view, visit https://gerrit.wikimedia.org/r/104728 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I46ae3ce2f39b35af6d75a94b5132eea0e6672064 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CodeEditor Gerrit-Branch: master Gerrit-Owner: Siebrand <siebr...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits