UltrasonicNXT has uploaded a new change for review.
https://gerrit.wikimedia.org/r/104756
Change subject: Fix some users appearing twice in the user list
......................................................................
Fix some users appearing twice in the user list
It seems this was not updated with the user object change, and I've also
simplyfied the code slightly
Change-Id: Ie5206199c7bac087c1233fb30aa426104a0ec749
---
M MediaWikiChat.js
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MediaWikiChat
refs/changes/56/104756/1
diff --git a/MediaWikiChat.js b/MediaWikiChat.js
index e63ca96..38e4d75 100644
--- a/MediaWikiChat.js
+++ b/MediaWikiChat.js
@@ -366,11 +366,11 @@
var add = true;
- $.each( $( '#mwchat-users div' ), ( function( index, item ) {
- if ( item.id == user.userE ) {
- add = false;
+ $( '#mwchat-users div' ).each( function( index ) {
+ if ( $( this ).attr( 'data-id' ) == user.id ) {
+ add = false;
+ }
}
- })
);
if ( add ) {
--
To view, visit https://gerrit.wikimedia.org/r/104756
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie5206199c7bac087c1233fb30aa426104a0ec749
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MediaWikiChat
Gerrit-Branch: master
Gerrit-Owner: UltrasonicNXT <adamr_car...@btinternet.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
