Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/104936
Change subject: Change Title::isExternal to use strict comparsion
......................................................................
Change Title::isExternal to use strict comparsion
Change-Id: Ib4e646f98dc6d17a8cb1ca837dcdc9d48f85e2a7
---
M includes/Title.php
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/36/104936/1
diff --git a/includes/Title.php b/includes/Title.php
index 0b4b99c..64cea91 100644
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -59,7 +59,7 @@
var $mDbkeyform = ''; // /< Main part with underscores
var $mUserCaseDBKey; // /< DB key with the initial letter
in the case specified by the user
var $mNamespace = NS_MAIN; // /< Namespace index, i.e. one of
the NS_xxxx constants
- var $mInterwiki = ''; // /< Interwiki prefix (or null
string)
+ var $mInterwiki = ''; // /< Interwiki prefix
var $mFragment; // /< Title fragment (i.e. the bit
after the #)
var $mArticleID = -1; // /< Article ID, fetched from the
link cache on demand
var $mLatestID = false; // /< ID of most recent revision
@@ -700,11 +700,11 @@
* @return Bool
*/
public function isExternal() {
- return ( $this->mInterwiki != '' );
+ return $this->mInterwiki !== '';
}
/**
- * Get the interwiki prefix (or null string)
+ * Get the interwiki prefix
*
* @return String Interwiki prefix
*/
--
To view, visit https://gerrit.wikimedia.org/r/104936
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4e646f98dc6d17a8cb1ca837dcdc9d48f85e2a7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
