jenkins-bot has submitted this change and it was merged.
Change subject: featured.py: decrease memory usage
......................................................................
featured.py: decrease memory usage
Instead of looping over the list, remove each item when it
has been processed. This saves roughly 60% memory (at least
on dewiki)
Change-Id: Idb2666d0664cbbddd7dcb011a89dddd3dd7d8948
---
M scripts/featured.py
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Merlijn van Deen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/featured.py b/scripts/featured.py
index a79770a..28a2630 100644
--- a/scripts/featured.py
+++ b/scripts/featured.py
@@ -398,7 +398,8 @@
pywikibot.output(
'\03{lightred}** %s has %i %s articles\03{default}'
% (site, len(articles), task))
- for p in articles:
+ while articles:
+ p = articles.pop(0)
if p.title() < afterpage:
continue
@@ -410,7 +411,7 @@
pywikibot.output(u"(cached) %s -> %s" % (p.title(),
cache[p.title()]))
continue
- yield copy(p)
+ yield p
def findTranslated(self, page, oursite=None):
quiet = self.getOption('quiet')
--
To view, visit https://gerrit.wikimedia.org/r/104915
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb2666d0664cbbddd7dcb011a89dddd3dd7d8948
Gerrit-PatchSet: 3
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <i...@gno.de>
Gerrit-Reviewer: DrTrigon <dr.tri...@surfeu.ch>
Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: Meno25 <meno25m...@gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhall...@arctus.nl>
Gerrit-Reviewer: Rotem Liss <roteml...@gmail.com>
Gerrit-Reviewer: Siebrand <siebr...@wikimedia.org>
Gerrit-Reviewer: Xqt <i...@gno.de>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
