jenkins-bot has submitted this change and it was merged.

Change subject: [browser test] change list_item to li
......................................................................


[browser test] change list_item to li

Both are valid, but using li is the convention.


Change-Id: Ic6929a1c8508760d0228c78fa132e1b1d92680a2
---
M modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jhall: Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb 
b/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb
index 3a0b2fe..02cc054 100644
--- a/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb
+++ b/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb
@@ -57,7 +57,7 @@
     span(:leftarrowclose, class: "oo-ui-iconedElement-icon 
oo-ui-icon-previous", frame: frame)
     text_field(:link_textfield, index: 0, frame: frame)
     span(:another_save_page, class: "oo-ui-labeledElement-label", text: "Save 
page", frame: frame)
-    list_item(:template_list_item, text: "S", frame: frame)
+    li(:template_list_item, text: "S", frame: frame)
     div(:ve_link_ui, class: "oo-ui-window-title", frame: frame)
   end
 

-- 
To view, visit https://gerrit.wikimedia.org/r/105208
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6929a1c8508760d0228c78fa132e1b1d92680a2
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>
Gerrit-Reviewer: Cmcmahon <cmcma...@wikimedia.org>
Gerrit-Reviewer: Jhall <jh...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to