jenkins-bot has submitted this change and it was merged. Change subject: Add sequence support for externallinks table ......................................................................
Add sequence support for externallinks table Database field el_id was added with Ib6b0fc3736d173fa4ba7b786ecfc710b2f4711bb, but due to autoincrement in mysql no sequence support was added. For mysql this is a nop, it adds a field to the insert but that is null and mysql autoincrement will fill it. INSERT /* LinksUpdate::incrTableUpdate 127.0.0.1 */ IGNORE INTO `externallinks` (el_id,el_from,el_to,el_index) VALUES (NULL,'1610','http://de.wikipedia.org/wiki/Hauptseite','http://org.wikipedia.de./wiki/Hauptseite') At least Oracle will need it Bug: 58435 Change-Id: I3f68ea8d99c5450c0c66feeb1469ef0ee6cc4eab --- M includes/deferred/LinksUpdate.php M maintenance/fixExtLinksProtocolRelative.php 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Freakolowsky: Looks good to me, but someone else must approve MarkAHershberger: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/deferred/LinksUpdate.php b/includes/deferred/LinksUpdate.php index d5ed250..6e0cebf 100644 --- a/includes/deferred/LinksUpdate.php +++ b/includes/deferred/LinksUpdate.php @@ -414,6 +414,7 @@ foreach ( $diffs as $url => $dummy ) { foreach ( wfMakeUrlIndexes( $url ) as $index ) { $arr[] = array( + 'el_id' => $this->mDb->nextSequenceValue( 'externallinks_el_id_seq' ), 'el_from' => $this->mId, 'el_to' => $url, 'el_index' => $index, diff --git a/maintenance/fixExtLinksProtocolRelative.php b/maintenance/fixExtLinksProtocolRelative.php index 55fbd9a..02d65ed 100644 --- a/maintenance/fixExtLinksProtocolRelative.php +++ b/maintenance/fixExtLinksProtocolRelative.php @@ -66,11 +66,13 @@ $db->insert( 'externallinks', array( array( + 'el_id' => $db->nextSequenceValue( 'externallinks_el_id_seq' ), 'el_from' => $row->el_from, 'el_to' => $row->el_to, 'el_index' => "http:{$row->el_index}", ), array( + 'el_id' => $db->nextSequenceValue( 'externallinks_el_id_seq' ), 'el_from' => $row->el_from, 'el_to' => $row->el_to, 'el_index' => "https:{$row->el_index}", -- To view, visit https://gerrit.wikimedia.org/r/105243 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f68ea8d99c5450c0c66feeb1469ef0ee6cc4eab Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender <umherirrender_de...@web.de> Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org> Gerrit-Reviewer: Freakolowsky <fr...@drajv.si> Gerrit-Reviewer: Lupo <lupo.bugzi...@gmail.com> Gerrit-Reviewer: MarkAHershberger <mhershber...@wikimedia.org> Gerrit-Reviewer: Parent5446 <tylerro...@gmail.com> Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
