Ottomata has submitted this change and it was merged.
Change subject: Add user-agent header to the format spec of EventLogging's
varnishncsa instance
......................................................................
Add user-agent header to the format spec of EventLogging's varnishncsa instance
User-agent strings often encode sufficiently many bits of information about the
user's
setup that they can be used to pinpoint an individual user, especially when
used in conjunction with other seemingly-anonymous datapoints. At the same
time, user-agent strings are indispensable for performance measurements and
front-end error reporting. Historically, the approach of EventLogging was to
leave user-agent logging and processing to developers and analysts. The problem
with this approach is that the anonymization of user-agent fields is not
uniform. When it is done at all, it is often done inconsistently. This often
ends up being a barrier for releasing performance-related datasets that would
greatly benefit from additional scrutiny.
The solution is to centralize the processing of user-agents at the time of data
collection. This way we can be confident that all UAs logged via EventLogging
are adequately anonymized.
The work is being done by the Analytics team (yay!). This is one piece of it.
This patch updates the log format specifier supplied to EventLogging's
varnishncsa instance to include the user-agent header.
Bug: 52295
Change-Id: Ia96008f80e0eee5a96412702b096d0eece7cfba7
---
M manifests/role/cache.pp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ottomata: Verified; Looks good to me, approved
diff --git a/manifests/role/cache.pp b/manifests/role/cache.pp
index e86a440..3456b8f 100644
--- a/manifests/role/cache.pp
+++ b/manifests/role/cache.pp
@@ -471,7 +471,7 @@
port => '8422',
instance_name => '',
cli_args => '-m RxURL:^/event\.gif\?. -D',
- log_fmt => "%q\t%l\t%n\t%t\t%h",
+ log_fmt => '%q\t%l\t%n\t%t\t%h\t"%{User-agent}i"',
monitor => false,
}
}
--
To view, visit https://gerrit.wikimedia.org/r/102817
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia96008f80e0eee5a96412702b096d0eece7cfba7
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: DarTar <dtarabore...@wikimedia.org>
Gerrit-Reviewer: Faidon Liambotis <fai...@wikimedia.org>
Gerrit-Reviewer: Milimetric <dandree...@wikimedia.org>
Gerrit-Reviewer: Nemo bis <federicol...@tiscali.it>
Gerrit-Reviewer: Nuria <nu...@wikimedia.org>
Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: Ottomata <o...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
