Siebrand has uploaded a new change for review. https://gerrit.wikimedia.org/r/106746
Change subject: Call Linker::link statically (1.18) ...................................................................... Call Linker::link statically (1.18) Change-Id: Ia47c1b3919ab4788813585c06ed8a93cdbfa496e --- M SelectCategory_body.php 1 file changed, 4 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SelectCategory refs/changes/46/106746/1 diff --git a/SelectCategory_body.php b/SelectCategory_body.php index cebe3e3..fc262de 100644 --- a/SelectCategory_body.php +++ b/SelectCategory_body.php @@ -27,7 +27,7 @@ # check if we should do anything or sleep if ( self::checkConditions( $isUpload, $pageObj ) ) { # Register CSS file for our select box - global $wgOut, $wgUser, $wgExtensionAssetsPath; + global $wgOut, $wgExtensionAssetsPath; global $wgSelectCategoryMaxLevel; global $wgSelectCategoryToplevelAllowed; @@ -36,17 +36,15 @@ $wgOut->addScriptFile( "{$wgExtensionAssetsPath}/SelectCategory/jquery.treeview.js" ); $wgOut->addScriptFile( "{$wgExtensionAssetsPath}/SelectCategory/SelectCategory.js" ); - $skin = $wgUser->getSkin(); - # Get all categories from wiki $allCats = self::getAllCategories( $isUpload ? NS_IMAGE : $pageObj->mTitle->getNamespace() ); # Load system messages - + # Get the right member variables, depending on if we're on an upload form or not if( !$isUpload ) { # Extract all categorylinks from page $pageCats = self::getPageCategories( $pageObj ); - + # Never ever use editFormTextTop here as it resides outside # the <form> so we will never get contents $place = 'editFormTextAfterWarn'; @@ -112,7 +110,7 @@ if ($level > 0 || $wgSelectCategoryToplevelAllowed) { $pageObj->$place .= '<input type="checkbox" name="SelectCategoryList[]" value="'.$category.'" class="checkbox" '.$checked.' />'; } - $pageObj->$place .= $skin->link( $title, $catName )."\n"; + $pageObj->$place .= Linker::link( $title, $catName )."\n"; # set id for next level $level_id = 'sc_'.$cat; -- To view, visit https://gerrit.wikimedia.org/r/106746 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia47c1b3919ab4788813585c06ed8a93cdbfa496e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SelectCategory Gerrit-Branch: master Gerrit-Owner: Siebrand <siebr...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits