Eranroz has uploaded a new change for review. https://gerrit.wikimedia.org/r/107432
Change subject: Bugfix: Allow dynamic registering of new tools ...................................................................... Bugfix: Allow dynamic registering of new tools Fixing bug that cause tools to be detroyed when calling ve.ui.toolFactory.register for new tool Change-Id: I28905b195d5a616363780cccbdfd3aa1cc463f56 --- M AUTHORS.txt M src/OO.ui.ToolGroup.js 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/32/107432/1 diff --git a/AUTHORS.txt b/AUTHORS.txt index cc1ba49..c9c3d7d 100644 --- a/AUTHORS.txt +++ b/AUTHORS.txt @@ -10,6 +10,7 @@ Amir Aharoni <aahar...@wikimedia.org> Bartosz Dziewoński <matma....@gmail.com> +Eranroz <eranro...@gmail.com> Erik Moeller <e...@wikimedia.org> Erick Guan <fantasticfe...@gmail.com> Inez Korczyński <i...@wikia-inc.com> diff --git a/src/OO.ui.ToolGroup.js b/src/OO.ui.ToolGroup.js index 9b9dc52..de4c1e0 100644 --- a/src/OO.ui.ToolGroup.js +++ b/src/OO.ui.ToolGroup.js @@ -238,8 +238,8 @@ } this.toolbar.reserveTool( tool ); add.push( tool ); - names[name] = true; } + names[name] = true; } // Remove tools that are no longer needed for ( name in this.tools ) { -- To view, visit https://gerrit.wikimedia.org/r/107432 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I28905b195d5a616363780cccbdfd3aa1cc463f56 Gerrit-PatchSet: 1 Gerrit-Project: oojs/ui Gerrit-Branch: master Gerrit-Owner: Eranroz <eranro...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits