Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/107866
Change subject: Clean up and doc fixes (submodule update) ...................................................................... Clean up and doc fixes (submodule update) * Remove odd comment and move node property to list of properties. * Update submodule to include: - (0bce7f6) Clean up CONTRIBUTING.md and README.md for VE core - (c10a2b5) ve.init.Target: Fix $document property documentation Change-Id: Ife3161bbdbf01075e987e65d9bfef41994efa916 --- M lib/ve M modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js 2 files changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/66/107866/1 diff --git a/lib/ve b/lib/ve index e699956..6645b10 160000 --- a/lib/ve +++ b/lib/ve -Subproject commit e699956799924a3f6d39efd928bbb7b83458935b +Subproject commit 6645b100a3f5cd8e03e512188c9830e02b4d7495 diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js b/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js index 9812f0b..d394e6a 100644 --- a/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js +++ b/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js @@ -179,10 +179,8 @@ // Parent method ve.ui.MWDialog.prototype.setup.call( this, data ); - // Sanity check - this.node = this.surface.getView().getFocusedNode(); - // Properties + this.node = this.surface.getView().getFocusedNode(); this.transclusion = new ve.dm.MWTransclusionModel(); this.loaded = false; -- To view, visit https://gerrit.wikimedia.org/r/107866 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ife3161bbdbf01075e987e65d9bfef41994efa916 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Krinkle <krinklem...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits