Ottomata has uploaded a new change for review. https://gerrit.wikimedia.org/r/107904
Change subject: Fixing threshold for varnishkafka drerr alert ...................................................................... Fixing threshold for varnishkafka drerr alert Also fixing comments in check_ganglia define Change-Id: Icc05cd2adbb4db3e57d8ee321b97bc6ebce867ff --- M manifests/nagios.pp M manifests/role/cache.pp 2 files changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/04/107904/1 diff --git a/manifests/nagios.pp b/manifests/nagios.pp index c6282c1..56aee75 100644 --- a/manifests/nagios.pp +++ b/manifests/nagios.pp @@ -359,9 +359,9 @@ # $ARG1$ -g gmetad host # $ARG2$ -p gmetad xml query port # $ARG3$ -H Host for which we want metrics - # $ARG3$ -m ganglia metric name - # $ARG4$ -w warning threshold - # $ARG5$ -c critical threshold + # $ARG4$ -m ganglia metric name + # $ARG5$ -w warning threshold + # $ARG6$ -c critical threshold monitor_service { $title: ensure => $ensure, diff --git a/manifests/role/cache.pp b/manifests/role/cache.pp index 0490b96..826558b 100644 --- a/manifests/role/cache.pp +++ b/manifests/role/cache.pp @@ -450,8 +450,9 @@ monitor_ganglia { 'varnishkafka-drerr': description => 'Varnishkafka Delivery Errors', metric => 'kafka.varnishkafka.kafka_drerr.per_second', - warning => '0.0', - critical => '0.0', + # alert if this is anything other than 0.0 + warning => '!0.0:0.0', + critical => '!0.0:0.0', require => Class['::varnishkafka::monitoring'], } } -- To view, visit https://gerrit.wikimedia.org/r/107904 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icc05cd2adbb4db3e57d8ee321b97bc6ebce867ff Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Ottomata <o...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits