Adrian Lang has uploaded a new change for review.
https://gerrit.wikimedia.org/r/108505
Change subject: Cleanup global injections
......................................................................
Cleanup global injections
Change-Id: I85377bf5f000ba2234f7f357792d287d7b7c21ef
---
M lib/resources/formatters/ApiBasedValueFormatter.js
M lib/resources/formatters/wikibase.formatters.register.js
M lib/resources/jquery.ui/jquery.ui.TemplatedWidget.js
M
lib/resources/jquery.valueview.experts.wikibase/experts.wikibase.EntityIdInput.js
M
lib/resources/jquery.valueview.experts.wikibase/experts.wikibase.EntityIdValue.js
M lib/resources/jquery.valueview.experts.wikibase/experts.wikibase.js
M lib/resources/jquery.wikibase/jquery.wikibase.claimlistview.js
M lib/resources/jquery.wikibase/jquery.wikibase.listview.ListItemAdapter.js
M lib/resources/jquery.wikibase/jquery.wikibase.listview.js
M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.ViewState.js
M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
M
lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Value.js
M
lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Variation.js
M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.js
M lib/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js
M lib/resources/jquery.wikibase/toolbar/movetoolbar.js
M lib/resources/jquery.wikibase/toolbar/removetoolbar.js
M lib/resources/jquery.wikibase/toolbar/toolbar.js
M lib/resources/jquery.wikibase/toolbar/toolbarbase.js
M lib/resources/jquery.wikibase/toolbar/toolbarbutton.js
M lib/resources/jquery.wikibase/toolbar/toolbarcontroller.js
M lib/resources/jquery.wikibase/toolbar/toolbareditgroup.js
M lib/resources/wikibase.RepoApi/wikibase.AbstractedRepoApi.js
M lib/resources/wikibase.RevisionStore.js
M lib/resources/wikibase.ui.Base.js
M lib/resources/wikibase.utilities/wikibase.utilities.ClaimGuidGenerator.js
M lib/resources/wikibase.utilities/wikibase.utilities.GuidGenerator.js
M lib/resources/wikibase.utilities/wikibase.utilities.jQuery.js
M lib/resources/wikibase.utilities/wikibase.utilities.ui.StatableObject.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.listview.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.siteselector.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.snaklistview.tests.js
M
lib/tests/qunit/jquery.wikibase/jquery.wikibase.statementview.RankSelector.tests.js
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.wbtooltip.tests.js
M lib/tests/qunit/jquery.wikibase/toolbar/movetoolbar.tests.js
M lib/tests/qunit/jquery.wikibase/toolbar/toolbar.tests.js
M lib/tests/qunit/jquery.wikibase/toolbar/toolbarbutton.tests.js
M lib/tests/qunit/jquery.wikibase/toolbar/toolbareditgroup.tests.js
M lib/tests/qunit/jquery.wikibase/toolbar/toolbarlabel.tests.js
M lib/tests/qunit/wikibase.ui.SiteLinksEditTool.tests.js
41 files changed, 83 insertions(+), 89 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/05/108505/1
diff --git a/lib/resources/formatters/ApiBasedValueFormatter.js
b/lib/resources/formatters/ApiBasedValueFormatter.js
index 1e018a2..ae4c81d 100644
--- a/lib/resources/formatters/ApiBasedValueFormatter.js
+++ b/lib/resources/formatters/ApiBasedValueFormatter.js
@@ -2,7 +2,7 @@
* @licence GNU GPL v2+
* @author H. Snater < mediaw...@snater.com >
*/
-( function( mw, $, wb, vf ) {
+( function( $, wb, vf ) {
'use strict';
var PARENT = vf.ValueFormatter;
@@ -38,4 +38,4 @@
} );
-}( mediaWiki, jQuery, wikibase, valueFormatters ) );
+}( jQuery, wikibase, valueFormatters ) );
diff --git a/lib/resources/formatters/wikibase.formatters.register.js
b/lib/resources/formatters/wikibase.formatters.register.js
index 6b08e86..9e2efca 100644
--- a/lib/resources/formatters/wikibase.formatters.register.js
+++ b/lib/resources/formatters/wikibase.formatters.register.js
@@ -2,7 +2,7 @@
* @licence GNU GPL v2+
* @author H. Snater < mediaw...@snater.com >
*/
-( function( mw, wb, vf, dv ) {
+( function( mw, wb, dv ) {
'use strict';
// Register Wikibase specific formatter:
@@ -12,4 +12,4 @@
wb.formatters.QuantityFormatter
);
-}( mediaWiki, wikibase, valueFormatters, dataValues ) );
+}( mediaWiki, wikibase, dataValues ) );
diff --git a/lib/resources/jquery.ui/jquery.ui.TemplatedWidget.js
b/lib/resources/jquery.ui/jquery.ui.TemplatedWidget.js
index 3fe8978..b71d822 100644
--- a/lib/resources/jquery.ui/jquery.ui.TemplatedWidget.js
+++ b/lib/resources/jquery.ui/jquery.ui.TemplatedWidget.js
@@ -3,7 +3,7 @@
* @licence GNU GPL v2+
* @author Daniel Werner < daniel.wer...@wikimedia.de >
*/
-( function( mw, wb, $ ) {
+( function( wb, $ ) {
'use strict';
var PARENT = $.Widget;
@@ -134,4 +134,4 @@
}
} );
-}( mediaWiki, wikibase, jQuery ) );
+}( wikibase, jQuery ) );
diff --git
a/lib/resources/jquery.valueview.experts.wikibase/experts.wikibase.EntityIdInput.js
b/lib/resources/jquery.valueview.experts.wikibase/experts.wikibase.EntityIdInput.js
index 048382d..ff1b016 100644
---
a/lib/resources/jquery.valueview.experts.wikibase/experts.wikibase.EntityIdInput.js
+++
b/lib/resources/jquery.valueview.experts.wikibase/experts.wikibase.EntityIdInput.js
@@ -2,7 +2,7 @@
* @licence GNU GPL v2+
* @author Daniel Werner < daniel.wer...@wikimedia.de >
*/
-( function( mw, wb, dv, $, vv ) {
+( function( mw, wb, $, vv ) {
'use strict';
// temporarily define a hard coded prefix map until we get this from
the server
@@ -164,4 +164,4 @@
}
} );
-}( mediaWiki, wikibase, dataValues, jQuery, jQuery.valueview ) );
+}( mediaWiki, wikibase, jQuery, jQuery.valueview ) );
diff --git
a/lib/resources/jquery.valueview.experts.wikibase/experts.wikibase.EntityIdValue.js
b/lib/resources/jquery.valueview.experts.wikibase/experts.wikibase.EntityIdValue.js
index a78d36a..cf73014 100644
---
a/lib/resources/jquery.valueview.experts.wikibase/experts.wikibase.EntityIdValue.js
+++
b/lib/resources/jquery.valueview.experts.wikibase/experts.wikibase.EntityIdValue.js
@@ -2,7 +2,7 @@
* @licence GNU GPL v2+
* @author Daniel Werner < daniel.wer...@wikimedia.de >
*/
-( function( mw, wb, dv, $, vv ) {
+( function( mw, wb, $, vv ) {
'use strict';
// temporarily define a hard coded prefix map until we get this from
the server
@@ -90,4 +90,4 @@
vv.experts.wikibase.EntityIdValue
);
-}( mediaWiki, wikibase, dataValues, jQuery, jQuery.valueview ) );
+}( mediaWiki, wikibase, jQuery, jQuery.valueview ) );
diff --git
a/lib/resources/jquery.valueview.experts.wikibase/experts.wikibase.js
b/lib/resources/jquery.valueview.experts.wikibase/experts.wikibase.js
index 92f7450..8e5840a 100644
--- a/lib/resources/jquery.valueview.experts.wikibase/experts.wikibase.js
+++ b/lib/resources/jquery.valueview.experts.wikibase/experts.wikibase.js
@@ -2,7 +2,7 @@
* @licence GNU GPL v2+
* @author Daniel Werner < daniel.wer...@wikimedia.de >
*/
-( function( wb, $, vv ) {
+( function( vv ) {
'use strict';
/**
@@ -11,4 +11,4 @@
*/
vv.experts.wikibase = {};
-}( wikibase, jQuery, jQuery.valueview ) );
+}( jQuery.valueview ) );
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.claimlistview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.claimlistview.js
index 85c3a8c..f202d0e 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.claimlistview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.claimlistview.js
@@ -2,7 +2,7 @@
* @licence GNU GPL v2+
* @author H. Snater < mediaw...@snater.com >
*/
-( function( mw, wb, $ ) {
+( function( wb, $ ) {
'use strict';
var PARENT = $.TemplatedWidget;
@@ -476,4 +476,4 @@
}
} );
-}( mediaWiki, wikibase, jQuery ) );
+}( wikibase, jQuery ) );
diff --git
a/lib/resources/jquery.wikibase/jquery.wikibase.listview.ListItemAdapter.js
b/lib/resources/jquery.wikibase/jquery.wikibase.listview.ListItemAdapter.js
index 2b25b33..a453f4d 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.listview.ListItemAdapter.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.listview.ListItemAdapter.js
@@ -3,7 +3,7 @@
* @licence GNU GPL v2+
* @author Daniel Werner < daniel.wer...@wikimedia.de >
*/
-( function( mw, wb, $ ) {
+( function( $ ) {
'use strict';
/**
@@ -24,7 +24,7 @@
*
* @option listItemWidget {Function} (required) The constructor of the
jQuery widget which
* should represent items in a list using this ListItemAdapter
definition.
- *
+ *
* @option newItemOptionsFn {Function} (required) A callback which will
be called when the
* related list is instantiating a new list item. The callback
has to return an Object
* which will then be used as options object for a new widget
(specified in
@@ -151,4 +151,4 @@
}
} );
-}( mediaWiki, wikibase, jQuery ) );
+}( jQuery ) );
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.listview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.listview.js
index b886a88..8a4a4f1 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.listview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.listview.js
@@ -4,7 +4,7 @@
* @author Daniel Werner < daniel.wer...@wikimedia.de >
* @author H. Snater < mediaw...@snater.com >
*/
-( function( mw, wb, $ ) {
+( function( $ ) {
'use strict';
var PARENT = $.TemplatedWidget;
@@ -361,4 +361,4 @@
} );
-}( mediaWiki, wikibase, jQuery ) );
+}( jQuery ) );
diff --git
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.ViewState.js
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.ViewState.js
index ddb2294..539b468 100644
---
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.ViewState.js
+++
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.ViewState.js
@@ -3,7 +3,7 @@
* @licence GNU GPL v2+
* @author Daniel Werner < daniel.wer...@wikimedia.de >
*/
-( function( mw, wb, $ ) {
+( function( $ ) {
'use strict';
/**
@@ -69,4 +69,4 @@
}
} );
-}( mediaWiki, wikibase, jQuery ) );
+}( jQuery ) );
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
index 0cadd00..843c8a0 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
@@ -4,7 +4,7 @@
* @author Daniel Werner < daniel.wer...@wikimedia.de >
* @author H. Snater < mediaw...@snater.com >
*/
-( function( mw, wb, dt, $ ) {
+( function( mw, wb, $ ) {
'use strict';
var PARENT = $.TemplatedWidget;
@@ -912,4 +912,4 @@
}
} );
-}( mediaWiki, wikibase, dataTypes, jQuery ) );
+}( mediaWiki, wikibase, jQuery ) );
diff --git
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Value.js
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Value.js
index af4d714..87191c4 100644
---
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Value.js
+++
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Value.js
@@ -3,7 +3,7 @@
* @licence GNU GPL v2+
* @author Daniel Werner < daniel.wer...@wikimedia.de >
*/
-( function( mw, wb, dv, dt, $ ) {
+( function( mw, wb, $ ) {
'use strict';
var MODULE = $.wikibase.snakview.variations,
@@ -308,4 +308,4 @@
}
} );
-}( mediaWiki, wikibase, dataValues, dataTypes, jQuery ) );
+}( mediaWiki, wikibase, jQuery ) );
diff --git
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Variation.js
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Variation.js
index 2ee079c..2d40df0 100644
---
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Variation.js
+++
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Variation.js
@@ -3,7 +3,7 @@
* @licence GNU GPL v2+
* @author Daniel Werner < daniel.wer...@wikimedia.de >
*/
-( function( mw, wb, $ ) {
+( function( wb, $ ) {
'use strict';
/**
@@ -173,4 +173,4 @@
blur: function() {}
} );
-}( mediaWiki, wikibase, jQuery ) );
+}( wikibase, jQuery ) );
diff --git
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.js
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.js
index 36e30e1..fb27abf 100644
---
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.js
+++
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.js
@@ -3,7 +3,7 @@
* @licence GNU GPL v2+
* @author Daniel Werner < daniel.wer...@wikimedia.de >
*/
-( function( mw, wb, $ ) {
+( function( wb, $ ) {
'use strict';
var MODULE = $.wikibase.snakview.variations;
@@ -128,4 +128,4 @@
}
};
-}( mediaWiki, wikibase, jQuery ) );
+}( wikibase, jQuery ) );
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js
b/lib/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js
index 8eddd00..1fe5564 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.wbtooltip.js
@@ -2,7 +2,7 @@
* @licence GNU GPL v2+
* @author H. Snater < mediaw...@snater.com >
*/
-( function( mw, wb, $ ) {
+( function( mw, $ ) {
'use strict';
@@ -321,4 +321,4 @@
} );
-} )( mediaWiki, wikibase, jQuery );
+} )( mediaWiki, jQuery );
diff --git a/lib/resources/jquery.wikibase/toolbar/movetoolbar.js
b/lib/resources/jquery.wikibase/toolbar/movetoolbar.js
index 1bc41ca..367b90b 100644
--- a/lib/resources/jquery.wikibase/toolbar/movetoolbar.js
+++ b/lib/resources/jquery.wikibase/toolbar/movetoolbar.js
@@ -2,7 +2,7 @@
* @licence GNU GPL v2+
* @author H. Snater < mediaw...@snater.com >
*/
-( function( mw, wb, $ ) {
+( function( mw, $ ) {
'use strict';
var PARENT = $.wikibase.toolbarbase;
@@ -118,4 +118,4 @@
} );
-}( mediaWiki, wikibase, jQuery ) );
+}( mediaWiki, jQuery ) );
diff --git a/lib/resources/jquery.wikibase/toolbar/removetoolbar.js
b/lib/resources/jquery.wikibase/toolbar/removetoolbar.js
index 122b5f5..012aa11 100644
--- a/lib/resources/jquery.wikibase/toolbar/removetoolbar.js
+++ b/lib/resources/jquery.wikibase/toolbar/removetoolbar.js
@@ -3,7 +3,7 @@
* @licence GNU GPL v2+
* @author H. Snater < mediaw...@snater.com >
*/
-( function( mw, wb, $ ) {
+( function( mw, $ ) {
'use strict';
var PARENT = $.wikibase.toolbarbase;
@@ -83,4 +83,4 @@
} );
-}( mediaWiki, wikibase, jQuery ) );
+}( mediaWiki, jQuery ) );
diff --git a/lib/resources/jquery.wikibase/toolbar/toolbar.js
b/lib/resources/jquery.wikibase/toolbar/toolbar.js
index 835437f..03647b9 100644
--- a/lib/resources/jquery.wikibase/toolbar/toolbar.js
+++ b/lib/resources/jquery.wikibase/toolbar/toolbar.js
@@ -4,7 +4,7 @@
* @author H. Snater < mediaw...@snater.com >
* @author Daniel Werner
*/
-( function( mw, wb, $ ) {
+( function( wb, $ ) {
'use strict';
var PARENT = $.Widget;
@@ -326,4 +326,4 @@
} );
-} )( mediaWiki, wikibase, jQuery );
+} )( wikibase, jQuery );
diff --git a/lib/resources/jquery.wikibase/toolbar/toolbarbase.js
b/lib/resources/jquery.wikibase/toolbar/toolbarbase.js
index 782a199..5c7e0ca 100644
--- a/lib/resources/jquery.wikibase/toolbar/toolbarbase.js
+++ b/lib/resources/jquery.wikibase/toolbar/toolbarbase.js
@@ -2,7 +2,7 @@
* @licence GNU GPL v2+
* @author H. Snater < mediaw...@snater.com >
*/
-( function( mw, wb, $ ) {
+( function( mw, $ ) {
'use strict';
/**
@@ -45,4 +45,4 @@
} );
-}( mediaWiki, wikibase, jQuery ) );
+}( mediaWiki, jQuery ) );
diff --git a/lib/resources/jquery.wikibase/toolbar/toolbarbutton.js
b/lib/resources/jquery.wikibase/toolbar/toolbarbutton.js
index b861bd0..8f97e4e 100644
--- a/lib/resources/jquery.wikibase/toolbar/toolbarbutton.js
+++ b/lib/resources/jquery.wikibase/toolbar/toolbarbutton.js
@@ -3,7 +3,7 @@
* @licence GNU GPL v2+
* @author H. Snater < mediaw...@snater.com >
*/
-( function( mw, wb, $ ) {
+( function( $ ) {
'use strict';
var PARENT = $.wikibase.toolbarlabel;
@@ -83,4 +83,4 @@
} );
-} )( mediaWiki, wikibase, jQuery );
+} )( jQuery );
diff --git a/lib/resources/jquery.wikibase/toolbar/toolbarcontroller.js
b/lib/resources/jquery.wikibase/toolbar/toolbarcontroller.js
index fc55dec..96643eb 100644
--- a/lib/resources/jquery.wikibase/toolbar/toolbarcontroller.js
+++ b/lib/resources/jquery.wikibase/toolbar/toolbarcontroller.js
@@ -2,7 +2,7 @@
* @licence GNU GPL v2+
* @author H. Snater < mediaw...@snater.com >
*/
-( function( mw, wb, $ ) {
+( function( $ ) {
'use strict';
/**
@@ -276,4 +276,4 @@
return eventNames.join( '.' + namespaces.join( '.' ) + ' ' );
}
-}( mediaWiki, wikibase, jQuery ) );
+}( jQuery ) );
diff --git a/lib/resources/jquery.wikibase/toolbar/toolbareditgroup.js
b/lib/resources/jquery.wikibase/toolbar/toolbareditgroup.js
index 5b35673..6176988 100644
--- a/lib/resources/jquery.wikibase/toolbar/toolbareditgroup.js
+++ b/lib/resources/jquery.wikibase/toolbar/toolbareditgroup.js
@@ -26,7 +26,7 @@
* @event remove: Triggered when clicking (hitting enter on) the remove button.
* (1) {jQuery.Event}
*/
-( function( mw, wb, $ ) {
+( function( mw, $ ) {
'use strict';
var PARENT = $.wikibase.toolbar;
@@ -336,4 +336,4 @@
} );
-}( mediaWiki, wikibase, jQuery ) );
+}( mediaWiki, jQuery ) );
diff --git a/lib/resources/wikibase.RepoApi/wikibase.AbstractedRepoApi.js
b/lib/resources/wikibase.RepoApi/wikibase.AbstractedRepoApi.js
index 40a8171..781558d 100644
--- a/lib/resources/wikibase.RepoApi/wikibase.AbstractedRepoApi.js
+++ b/lib/resources/wikibase.RepoApi/wikibase.AbstractedRepoApi.js
@@ -5,7 +5,7 @@
* @author H. Snater < mediaw...@snater.com >
* @author Marius Hoch < h...@online.de >
*/
-( function( mw, wb, $ ) {
+( function( wb, $ ) {
'use strict';
/**
@@ -267,4 +267,4 @@
}
} );
-}( mediaWiki, wikibase, jQuery ) );
+}( wikibase, jQuery ) );
diff --git a/lib/resources/wikibase.RevisionStore.js
b/lib/resources/wikibase.RevisionStore.js
index f1841e7..504cf5d 100644
--- a/lib/resources/wikibase.RevisionStore.js
+++ b/lib/resources/wikibase.RevisionStore.js
@@ -5,7 +5,7 @@
* @licence GNU GPL v2+
* @author Tobias Gritschacher
*/
-( function( mw, wb, $ ) {
+( function( wb, $ ) {
'use strict';
/**
@@ -109,4 +109,4 @@
}
} );
-}( mediaWiki, wikibase, jQuery ) );
+}( wikibase, jQuery ) );
diff --git a/lib/resources/wikibase.ui.Base.js
b/lib/resources/wikibase.ui.Base.js
index 846c9ec..7648f86 100644
--- a/lib/resources/wikibase.ui.Base.js
+++ b/lib/resources/wikibase.ui.Base.js
@@ -6,7 +6,7 @@
* @author Daniel Werner < daniel.werner at wikimedia.de >
* @author H. Snater <mediaw...@snater.com>
*/
-( function( mw, wb, $ ) {
+( function( wb, $ ) {
'use strict';
/**
@@ -186,4 +186,4 @@
wb.utilities.ObservableObject.useWith( wb.ui.Base );
-}( mediaWiki, wikibase, jQuery ) );
+}( wikibase, jQuery ) );
diff --git
a/lib/resources/wikibase.utilities/wikibase.utilities.ClaimGuidGenerator.js
b/lib/resources/wikibase.utilities/wikibase.utilities.ClaimGuidGenerator.js
index 021ab36..241869d 100644
--- a/lib/resources/wikibase.utilities/wikibase.utilities.ClaimGuidGenerator.js
+++ b/lib/resources/wikibase.utilities/wikibase.utilities.ClaimGuidGenerator.js
@@ -4,7 +4,7 @@
* @licence GNU GPL v2+
* @author H. Snater < mediaw...@snater.com >
*/
-( function( mw, wb, $ ) {
+( function( wb, $ ) {
'use strict';
/**
@@ -27,4 +27,4 @@
}
} );
-}( mediaWiki, wikibase, jQuery ) );
+}( wikibase, jQuery ) );
diff --git
a/lib/resources/wikibase.utilities/wikibase.utilities.GuidGenerator.js
b/lib/resources/wikibase.utilities/wikibase.utilities.GuidGenerator.js
index fcd6216..dd8059c 100644
--- a/lib/resources/wikibase.utilities/wikibase.utilities.GuidGenerator.js
+++ b/lib/resources/wikibase.utilities/wikibase.utilities.GuidGenerator.js
@@ -4,7 +4,7 @@
* @licence GNU GPL v2+
* @author H. Snater < mediaw...@snater.com >
*/
-( function( mw, wb, $ ) {
+( function( wb, $ ) {
'use strict';
/**
@@ -80,4 +80,4 @@
}
);
-} )( mediaWiki, wikibase, jQuery );
+} )( wikibase, jQuery );
diff --git a/lib/resources/wikibase.utilities/wikibase.utilities.jQuery.js
b/lib/resources/wikibase.utilities/wikibase.utilities.jQuery.js
index 5015a9c..0d0773e 100644
--- a/lib/resources/wikibase.utilities/wikibase.utilities.jQuery.js
+++ b/lib/resources/wikibase.utilities/wikibase.utilities.jQuery.js
@@ -6,7 +6,7 @@
* @author Daniel Werner
* @author H. Snater
*/
-( function( $, mw, wb ) {
+( function( $, wb ) {
'use strict';
// make this usable without base utilities
@@ -99,4 +99,4 @@
};
};
-}( jQuery, mediaWiki, wikibase ) );
+}( jQuery, wikibase ) );
diff --git
a/lib/resources/wikibase.utilities/wikibase.utilities.ui.StatableObject.js
b/lib/resources/wikibase.utilities/wikibase.utilities.ui.StatableObject.js
index 938825a..6169ae1 100644
--- a/lib/resources/wikibase.utilities/wikibase.utilities.ui.StatableObject.js
+++ b/lib/resources/wikibase.utilities/wikibase.utilities.ui.StatableObject.js
@@ -5,7 +5,7 @@
* @licence GNU GPL v2+
* @author H. Snater
*/
-( function( mw, wb ) {
+( function( wb ) {
'use strict';
// make sure wb.utilities.ui exists, move this into its own file as
soon as there are more than this utility!
@@ -105,4 +105,4 @@
} );
-} )( mediaWiki, wikibase );
+} )( wikibase );
diff --git a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimview.tests.js
index c028dcb..88159f6 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimview.tests.js
@@ -2,7 +2,7 @@
* @licence GNU GPL v2+
* @author Adrian Lang < adrian.l...@wikimedia.de >
*/
-( function( $, mw, wb ) {
+( function( mw, QUnit ) {
'use strict';
function createClaimview( value ) {
@@ -32,4 +32,4 @@
'Destroyed listview.'
);
} );
-} )( jQuery, mediaWiki, wikibase );
+} )( mediaWiki, QUnit );
diff --git a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.listview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.listview.tests.js
index be254ed..ca8d86f 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.listview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.listview.tests.js
@@ -1,9 +1,8 @@
/**
- * @since 0.4
* @licence GNU GPL v2+
* @author H. Snater < mediaw...@snater.com >
*/
-( function( $, mw, wb ) {
+( function( $, QUnit ) {
'use strict';
/**
@@ -422,4 +421,4 @@
} );
} );
-} )( jQuery, mediaWiki, wikibase );
+} )( jQuery, QUnit );
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.siteselector.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.siteselector.tests.js
index cf8f5b6..9434989 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.siteselector.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.siteselector.tests.js
@@ -1,11 +1,9 @@
/**
- * @since 0.1
- *
* @licence GNU GPL v2+
* @author H. Snater < mediaw...@snater.com >
*/
-( function( mw, wb, $, QUnit ) {
+( function( wb, $, QUnit ) {
'use strict';
/**
@@ -168,4 +166,4 @@
} );
-}( mediaWiki, wikibase, jQuery, QUnit ) );
+}( wikibase, jQuery, QUnit ) );
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.snaklistview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.snaklistview.tests.js
index 05aefc1..34d9f4b 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.snaklistview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.snaklistview.tests.js
@@ -1,9 +1,8 @@
/**
- * @since 0.4
* @licence GNU GPL v2+
* @author H. Snater < mediaw...@snater.com >
*/
-( function( $, mw, wb, dv ) {
+( function( $, wb, dv, QUnit ) {
'use strict';
var snakLists = [
@@ -898,4 +897,4 @@
testPropertyLabelVisibility( assert, snaklistview );
} );
-} )( jQuery, mediaWiki, wikibase, dataValues );
+} )( jQuery, wikibase, dataValues, QUnit );
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.statementview.RankSelector.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.statementview.RankSelector.tests.js
index 1f99d3d..85d7232 100644
---
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.statementview.RankSelector.tests.js
+++
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.statementview.RankSelector.tests.js
@@ -2,7 +2,7 @@
* @licence GNU GPL v2+
* @author H. Snater < mediaw...@snater.com >
*/
-( function( $, mw, wb ) {
+( function( $, wb, QUnit ) {
'use strict';
/**
@@ -173,4 +173,4 @@
} );
-} )( jQuery, mediaWiki, wikibase );
+} )( jQuery, wikibase, QUnit );
diff --git a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.wbtooltip.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.wbtooltip.tests.js
index 6ec4b88..c43ac37 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.wbtooltip.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.wbtooltip.tests.js
@@ -1,14 +1,12 @@
/**
- * @since 0.4
* @licence GNU GPL v2+
* @author H. Snater < mediaw...@snater.com >
*/
-( function( $, mw, wb ) {
+( function( $, wb, QUnit ) {
'use strict';
/**
* Initializes a tooltip suitable for testing.
- * @since 0.4
*
* @param {Object} options Tooltip widget options.
* @return {jQuery}
@@ -175,4 +173,4 @@
);
} );
-} )( jQuery, mediaWiki, wikibase );
+} )( jQuery, wikibase, QUnit );
diff --git a/lib/tests/qunit/jquery.wikibase/toolbar/movetoolbar.tests.js
b/lib/tests/qunit/jquery.wikibase/toolbar/movetoolbar.tests.js
index 6846b67..cec29f7 100644
--- a/lib/tests/qunit/jquery.wikibase/toolbar/movetoolbar.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/toolbar/movetoolbar.tests.js
@@ -5,7 +5,7 @@
* @author H. Snater < mediaw...@snater.com >
*/
-( function( mw, wb, $, QUnit ) {
+( function( $, QUnit ) {
'use strict';
/**
@@ -156,4 +156,4 @@
toolbar.$btnMoveDown.trigger( 'click' );
} );
-}( mediaWiki, wikibase, jQuery, QUnit ) );
+}( jQuery, QUnit ) );
diff --git a/lib/tests/qunit/jquery.wikibase/toolbar/toolbar.tests.js
b/lib/tests/qunit/jquery.wikibase/toolbar/toolbar.tests.js
index e02fed9..cc21cb1 100644
--- a/lib/tests/qunit/jquery.wikibase/toolbar/toolbar.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/toolbar/toolbar.tests.js
@@ -5,7 +5,7 @@
* @author H. Snater < mediaw...@snater.com >
*/
-( function( mw, wb, $, QUnit ) {
+( function( wb, $, QUnit ) {
'use strict';
QUnit.module( 'jQuery.wikibase.toolbar', QUnit.newWbEnvironment( {} ) );
@@ -240,4 +240,4 @@
} );
-}( mediaWiki, wikibase, jQuery, QUnit ) );
+}( wikibase, jQuery, QUnit ) );
diff --git a/lib/tests/qunit/jquery.wikibase/toolbar/toolbarbutton.tests.js
b/lib/tests/qunit/jquery.wikibase/toolbar/toolbarbutton.tests.js
index 27127a8..c7a7a40 100644
--- a/lib/tests/qunit/jquery.wikibase/toolbar/toolbarbutton.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/toolbar/toolbarbutton.tests.js
@@ -5,7 +5,7 @@
* @author H. Snater < mediawiki at snater.com >
*/
-( function( mw, wb, $, QUnit ) {
+( function( mw, $, QUnit ) {
'use strict';
/**
@@ -121,4 +121,4 @@
);
} );
-}( mediaWiki, wikibase, jQuery, QUnit ) );
+}( mediaWiki, jQuery, QUnit ) );
diff --git a/lib/tests/qunit/jquery.wikibase/toolbar/toolbareditgroup.tests.js
b/lib/tests/qunit/jquery.wikibase/toolbar/toolbareditgroup.tests.js
index 6d5f8b3..5c03abe 100644
--- a/lib/tests/qunit/jquery.wikibase/toolbar/toolbareditgroup.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/toolbar/toolbareditgroup.tests.js
@@ -5,7 +5,7 @@
* @author H. Snater < mediaw...@snater.com >
*/
-( function( wb, $, QUnit ) {
+( function( $, QUnit ) {
'use strict';
QUnit.module( 'jQuery.wikibase.toolbareditgroup',
QUnit.newWbEnvironment() );
@@ -108,4 +108,4 @@
} );
-}( wikibase, jQuery, QUnit ) );
+}( jQuery, QUnit ) );
diff --git a/lib/tests/qunit/jquery.wikibase/toolbar/toolbarlabel.tests.js
b/lib/tests/qunit/jquery.wikibase/toolbar/toolbarlabel.tests.js
index 518a5a5..bc58fc9 100644
--- a/lib/tests/qunit/jquery.wikibase/toolbar/toolbarlabel.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/toolbar/toolbarlabel.tests.js
@@ -5,7 +5,7 @@
* @author H. Snater < mediaw...@snater.com >
*/
-( function( wb, $, QUnit ) {
+( function( $, QUnit ) {
'use strict';
/**
@@ -120,4 +120,4 @@
} );
-}( wikibase, jQuery, QUnit ) );
+}( jQuery, QUnit ) );
diff --git a/lib/tests/qunit/wikibase.ui.SiteLinksEditTool.tests.js
b/lib/tests/qunit/wikibase.ui.SiteLinksEditTool.tests.js
index 2f3c8fa..da7622c 100644
--- a/lib/tests/qunit/wikibase.ui.SiteLinksEditTool.tests.js
+++ b/lib/tests/qunit/wikibase.ui.SiteLinksEditTool.tests.js
@@ -5,7 +5,7 @@
* @author Daniel Werner < daniel.wer...@wikimedia.de >
*/
-( function( mw, wb, $, QUnit ) {
+( function( wb, $, QUnit ) {
'use strict';
var config = {
@@ -344,4 +344,4 @@
} );
-}( mediaWiki, wikibase, jQuery, QUnit ) );
+}( wikibase, jQuery, QUnit ) );
--
To view, visit https://gerrit.wikimedia.org/r/108505
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I85377bf5f000ba2234f7f357792d287d7b7c21ef
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <adrian.l...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
