Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/108960
Change subject: Remove TODO for use of TRUNCATE and replace with comment
......................................................................
Remove TODO for use of TRUNCATE and replace with comment
The new comment explain why truncate is not possible
Change-Id: I8dacff0784a07a0e20a4da0cc71043379ded6eb0
---
M includes/MessageBlobStore.php
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/60/108960/1
diff --git a/includes/MessageBlobStore.php b/includes/MessageBlobStore.php
index 8a8142b..7e1c745 100644
--- a/includes/MessageBlobStore.php
+++ b/includes/MessageBlobStore.php
@@ -242,8 +242,9 @@
public static function clear() {
// TODO: Give this some more thought
- // TODO: Is TRUNCATE better?
try {
+ // Not using TRUNCATE, because that needs extra
permissions,
+ // which maybe not granted to the database user.
$dbw = wfGetDB( DB_MASTER );
$dbw->delete( 'msg_resource', '*', __METHOD__ );
$dbw->delete( 'msg_resource_links', '*', __METHOD__ );
--
To view, visit https://gerrit.wikimedia.org/r/108960
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8dacff0784a07a0e20a4da0cc71043379ded6eb0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
