Chad has submitted this change and it was merged.
Change subject: Call Linker methods statically
......................................................................
Call Linker methods statically
Change-Id: I3b4e3043de13b2f102c1451a75538d41d74a5520
---
M Maintenance_body.php
1 file changed, 5 insertions(+), 7 deletions(-)
Approvals:
Chad: Verified; Looks good to me, approved
diff --git a/Maintenance_body.php b/Maintenance_body.php
index c660eae..1da560f 100644
--- a/Maintenance_body.php
+++ b/Maintenance_body.php
@@ -81,8 +81,6 @@
$this->setHeaders();
$out = $this->getOutput();
$out->addWikiMsg( 'maintenance-header' );
-
- $sk = $this->getUser()->getSkin();
$out->addHTML( '<ul>' );
//scripts that we allow to run via this interface, from the
metadata.ini file
@@ -90,7 +88,7 @@
sort( $scripts );
foreach( $scripts as $type ) {
$title = $this->getTitle( $type );
- $out->addHTML( '<li>'. $sk->makeKnownLinkObj( $title,
htmlspecialchars( $type ) ) . ' -- '.
+ $out->addHTML( '<li>'. Linker::makeKnownLinkObj(
$title, htmlspecialchars( $type ) ) . ' -- '.
wfMessage( 'maintenance-'.$type.'-desc'
)->parse() . '</li>' );
}
$out->addHTML( '</ul>' );
@@ -101,7 +99,7 @@
$this->setHeaders();
$out = $this->getOutput();
- $out->addHTML( $this->getUser()->getSkin()->makeKnownLinkObj(
$this->getTitle(), wfMessage( 'maintenance-backlink' )->escaped() ). '<br />' );
+ $out->addHTML( Linker::makeKnownLinkObj( $this->getTitle(),
wfMessage( 'maintenance-backlink' )->escaped() ). '<br />' );
if( $this->errmsg ) {
$out->addWikiMsg( $this->errmsg );
@@ -145,7 +143,7 @@
$out = $this->getOutput();
$this->setHeaders();
- $out->addHTML( $this->getUser()->getSkin()->makeKnownLinkObj(
$this->getTitle(), wfMessage( 'maintenance-backlink' )->escaped() ). '<br />' );
+ $out->addHTML( Linker::makeKnownLinkObj( $this->getTitle(),
wfMessage( 'maintenance-backlink' )->escaped() ). '<br />' );
if( $this->errmsg ) {
$out->addWikiMsg( $this->errmsg );
@@ -166,7 +164,7 @@
str_replace(
array( 'dirname( __FILE__ )' ),
//search
array( '"$IP/maintenance"' ),
//replace
- preg_replace(
'/\s+(exit|die)\s*\(.*?\)\s*;/', ';',
+ preg_replace(
'/\s+(exit|die)\s*\(.*?\)\s*;/', ';',
file_get_contents(
"$IP/maintenance/sql.php" )
)
)
@@ -348,7 +346,7 @@
}
$out->addHTML( '</pre>' );
$this->scriptDone( $script );
- $out->addHTML( $this->getUser()->getSkin()->makeKnownLinkObj(
$this->getTitle(), wfMessage( 'maintenance-backlink' )->escaped() ). '<br />' );
+ $out->addHTML( Linker::makeKnownLinkObj( $this->getTitle(),
wfMessage( 'maintenance-backlink' )->escaped() ). '<br />' );
}
private function parseMetadata() {
--
To view, visit https://gerrit.wikimedia.org/r/106927
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b4e3043de13b2f102c1451a75538d41d74a5520
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Maintenance
Gerrit-Branch: master
Gerrit-Owner: Siebrand <siebr...@wikimedia.org>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: IAlex <coderev...@emsenhuber.ch>
Gerrit-Reviewer: NormalUser <c...@anyonecanedit.org>
Gerrit-Reviewer: Reedy <re...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
