Kaldari has uploaded a new change for review.
https://gerrit.wikimedia.org/r/109724
Change subject: Make sure previous.overlay is defined before using it
......................................................................
Make sure previous.overlay is defined before using it
In the case where an overlay doesn't completely load before the
user hits the back button, it would throw a JS error. This prevents
the error.
Change-Id: I00e37f99b32a15dc79a0d9c11ab485e33137bd6c
---
M javascripts/common/OverlayManager.js
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/24/109724/1
diff --git a/javascripts/common/OverlayManager.js
b/javascripts/common/OverlayManager.js
index aad1498..15a2d2b 100644
--- a/javascripts/common/OverlayManager.js
+++ b/javascripts/common/OverlayManager.js
@@ -61,7 +61,11 @@
} );
// force hide only if more overlays in stack
- if ( previous && this.hidePrevious &&
!previous.overlay.hide( this.stack.length > 1 ) ) {
+ if ( previous &&
+ previous.overlay !== undefined &&
+ this.hidePrevious &&
+ !previous.overlay.hide( this.stack.length > 1 )
+ ) {
// if hide prevented, prevent route change event
ev.preventDefault();
} else if ( !match ) {
--
To view, visit https://gerrit.wikimedia.org/r/109724
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I00e37f99b32a15dc79a0d9c11ab485e33137bd6c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Kaldari <rkald...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
