jenkins-bot has submitted this change and it was merged.
Change subject: Display error message if browser is not started for some reason
......................................................................
Display error message if browser is not started for some reason
Change-Id: I486c056c8302a112f384bcd1d7a9611f9d463cd7
---
M lib/mediawiki/selenium/sauce.rb
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Manybubbles: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/mediawiki/selenium/sauce.rb b/lib/mediawiki/selenium/sauce.rb
index 7d0cedb..d2b1aa2 100644
--- a/lib/mediawiki/selenium/sauce.rb
+++ b/lib/mediawiki/selenium/sauce.rb
@@ -13,8 +13,15 @@
module Cucumber::Formatter
class Sauce < Junit
+
+ private
+
def format_exception(exception)
- sauce_job_page = "Sauce Labs job URL:
http://saucelabs.com/jobs/#{$session_id}\n";
+ if $session_id
+ sauce_job_page = "Sauce Labs job URL:
http://saucelabs.com/jobs/#{$session_id}\n";
+ else
+ sauce_job_page = "Uh-oh. Could not find link to Sauce Labs job URL."
+ end
([sauce_job_page] + ["#{exception.message} (#{exception.class})"] +
exception.backtrace).join("\n")
end
end
--
To view, visit https://gerrit.wikimedia.org/r/110167
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I486c056c8302a112f384bcd1d7a9611f9d463cd7
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>
Gerrit-Reviewer: Amire80 <amir.ahar...@mail.huji.ac.il>
Gerrit-Reviewer: Cmcmahon <cmcma...@wikimedia.org>
Gerrit-Reviewer: Jhall <jh...@wikimedia.org>
Gerrit-Reviewer: Manybubbles <never...@wikimedia.org>
Gerrit-Reviewer: NikiWiki <mediawikidev100...@spam.game-host.org>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: Zfilipin <zfili...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
