Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/110485
Change subject: Add "Don't assume Snaks have a value in
wikibase.ui.scrapeFormattedValues"
......................................................................
Add "Don't assume Snaks have a value in wikibase.ui.scrapeFormattedValues"
Change-Id: Ice5a07212bca6a9b30734ed57427e258f01eefbc
---
M composer.lock
M extensions/Wikibase/repo/resources/wikibase.ui.scrapeFormattedValues.js
M vendor/autoload.php
M vendor/composer/autoload_real.php
M vendor/composer/installed.json
5 files changed, 15 insertions(+), 15 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikidata
refs/changes/85/110485/1
diff --git a/composer.lock b/composer.lock
index a81f0bf..2f7a4a7 100644
--- a/composer.lock
+++ b/composer.lock
@@ -847,12 +847,12 @@
"source": {
"type": "git",
"url":
"https://github.com/wikimedia/mediawiki-extensions-Wikibase.git";,
- "reference": "41c74325d6e7fe0c7eb04205ab5127ca9bdee05c"
+ "reference": "6560dd64e31fba3ae2a14ac3cadf6a38e26e474e"
},
"dist": {
"type": "zip",
- "url":
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/41c74325d6e7fe0c7eb04205ab5127ca9bdee05c";,
- "reference": "41c74325d6e7fe0c7eb04205ab5127ca9bdee05c",
+ "url":
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/6560dd64e31fba3ae2a14ac3cadf6a38e26e474e";,
+ "reference": "6560dd64e31fba3ae2a14ac3cadf6a38e26e474e",
"shasum": ""
},
"require": {
@@ -908,7 +908,7 @@
"wikibaserepo",
"wikidata"
],
- "time": "2014-01-30 20:24:31"
+ "time": "2014-01-31 00:55:14"
}
],
"packages-dev": [
diff --git
a/extensions/Wikibase/repo/resources/wikibase.ui.scrapeFormattedValues.js
b/extensions/Wikibase/repo/resources/wikibase.ui.scrapeFormattedValues.js
index 4a50750..ea22dfc 100644
--- a/extensions/Wikibase/repo/resources/wikibase.ui.scrapeFormattedValues.js
+++ b/extensions/Wikibase/repo/resources/wikibase.ui.scrapeFormattedValues.js
@@ -39,7 +39,7 @@
$.each( claim.getQualifiers().getGroupedSnakLists(),
function( j, snakList ) {
snakList.each( function( k, snak ) {
- if( snak.getValue().getType() ===
'quantity' ) {
+ if( snak.getType() === 'value' &&
snak.getValue().getType() === 'quantity' ) {
$claim = $claim ||
getClaimNode( claim.getGuid() );
$qualifierValues =
$qualifierValues || getQualifierValueNodes( $claim );
@@ -52,7 +52,7 @@
$.each( claim.getReferences(), function( j, reference )
{
$.each(
reference.getSnaks().getGroupedSnakLists(), function( j, snakList ) {
snakList.each( function( k, snak ) {
- if( snak.getValue().getType()
=== 'quantity' ) {
+ if( snak.getType() === 'value'
&& snak.getValue().getType() === 'quantity' ) {
$referenceValues
=
$referenceValues || getReferenceValueNodes( reference.getHash() );
diff --git a/vendor/autoload.php b/vendor/autoload.php
index 1881b0a..ec4d4f2 100644
--- a/vendor/autoload.php
+++ b/vendor/autoload.php
@@ -4,4 +4,4 @@
require_once __DIR__ . '/composer' . '/autoload_real.php';
-return ComposerAutoloaderInit21506b6a0fb3aa17ed87ba5eec11a81c::getLoader();
+return ComposerAutoloaderInitca1cf753f323c06d02cc6cbc9ca2c786::getLoader();
diff --git a/vendor/composer/autoload_real.php
b/vendor/composer/autoload_real.php
index 2e39e05..4a72164 100644
--- a/vendor/composer/autoload_real.php
+++ b/vendor/composer/autoload_real.php
@@ -2,7 +2,7 @@
// autoload_real.php @generated by Composer
-class ComposerAutoloaderInit21506b6a0fb3aa17ed87ba5eec11a81c
+class ComposerAutoloaderInitca1cf753f323c06d02cc6cbc9ca2c786
{
private static $loader;
@@ -19,9 +19,9 @@
return self::$loader;
}
-
spl_autoload_register(array('ComposerAutoloaderInit21506b6a0fb3aa17ed87ba5eec11a81c',
'loadClassLoader'), true, true);
+
spl_autoload_register(array('ComposerAutoloaderInitca1cf753f323c06d02cc6cbc9ca2c786',
'loadClassLoader'), true, true);
self::$loader = $loader = new \Composer\Autoload\ClassLoader();
-
spl_autoload_unregister(array('ComposerAutoloaderInit21506b6a0fb3aa17ed87ba5eec11a81c',
'loadClassLoader'));
+
spl_autoload_unregister(array('ComposerAutoloaderInitca1cf753f323c06d02cc6cbc9ca2c786',
'loadClassLoader'));
$vendorDir = dirname(__DIR__);
$baseDir = dirname($vendorDir);
diff --git a/vendor/composer/installed.json b/vendor/composer/installed.json
index e4301b9..c2e42a5 100644
--- a/vendor/composer/installed.json
+++ b/vendor/composer/installed.json
@@ -874,12 +874,12 @@
"source": {
"type": "git",
"url":
"https://github.com/wikimedia/mediawiki-extensions-Wikibase.git";,
- "reference": "41c74325d6e7fe0c7eb04205ab5127ca9bdee05c"
+ "reference": "6560dd64e31fba3ae2a14ac3cadf6a38e26e474e"
},
"dist": {
"type": "zip",
- "url":
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/41c74325d6e7fe0c7eb04205ab5127ca9bdee05c";,
- "reference": "41c74325d6e7fe0c7eb04205ab5127ca9bdee05c",
+ "url":
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/6560dd64e31fba3ae2a14ac3cadf6a38e26e474e";,
+ "reference": "6560dd64e31fba3ae2a14ac3cadf6a38e26e474e",
"shasum": ""
},
"require": {
@@ -898,9 +898,9 @@
"wikibase/data-model": "0.6.*",
"wikibase/easyrdf_lite": "*"
},
- "time": "2014-01-30 20:24:31",
+ "time": "2014-01-31 00:55:14",
"type": "mediawiki-extension",
- "installation-source": "source",
+ "installation-source": "dist",
"autoload": {
"files": [
"Wikibase.composer.php"
--
To view, visit https://gerrit.wikimedia.org/r/110485
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice5a07212bca6a9b30734ed57427e258f01eefbc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikidata
Gerrit-Branch: master
Gerrit-Owner: Hoo man <h...@online.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
