Mooeypoo has uploaded a new change for review. https://gerrit.wikimedia.org/r/110913
Change subject: Make {{ a parameter in the error message in the editor dialog ...................................................................... Make {{ a parameter in the error message in the editor dialog Translatewiki warns of an unbalanced parenthesis problem in the translation string. Turning the {{ into a parameter solves this issue. Change-Id: I2fd69b3e901175dad22d285aa2373916acd4f208 --- M TemplateData.i18n.php M modules/ext.templateDataGenerator.core.js 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TemplateData refs/changes/13/110913/1 diff --git a/TemplateData.i18n.php b/TemplateData.i18n.php index c057ce5..e4614da 100644 --- a/TemplateData.i18n.php +++ b/TemplateData.i18n.php @@ -41,7 +41,7 @@ 'templatedata-modal-button-cancel' => 'Cancel', 'templatedata-modal-button-delparam' => 'Delete parameter', 'templatedata-modal-button-importParams' => 'Import parameters', - 'templatedata-modal-errormsg' => 'Errors found. Please make sure there are no empty or duplicate parameter names, and that the parameter name does not include "|", "=" or "}}".', + 'templatedata-modal-errormsg' => 'Errors found. Please make sure there are no empty or duplicate parameter names, and that the parameter name does not include "|", "=" or "$1".', 'templatedata-modal-errormsg-import-noparams' => 'No new parameters found during import.', 'templatedata-modal-notice-import-numparams' => '$1 new {{PLURAL:$1|parameter was|parameters were}} imported.', 'templatedata-modal-table-param-actions' => 'Actions', diff --git a/modules/ext.templateDataGenerator.core.js b/modules/ext.templateDataGenerator.core.js index d2e8fe6..58581f7 100644 --- a/modules/ext.templateDataGenerator.core.js +++ b/modules/ext.templateDataGenerator.core.js @@ -482,7 +482,7 @@ // Validate if ( !doNotCheckForm ) { if ( !isFormValid() ) { - showErrorModal( mw.msg( 'templatedata-modal-errormsg' ) ); + showErrorModal( mw.msg( 'templatedata-modal-errormsg', '}}' ) ); return; } } -- To view, visit https://gerrit.wikimedia.org/r/110913 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2fd69b3e901175dad22d285aa2373916acd4f208 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TemplateData Gerrit-Branch: master Gerrit-Owner: Mooeypoo <mor...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits