Ottomata has submitted this change and it was merged.
Change subject: Adding varnish.client_req to varnishkafka ganglia view
......................................................................
Adding varnish.client_req to varnishkafka ganglia view
Also converting some graphs from stack to line
Change-Id: I1b8b89a88544074401fc7d696961b4b2f6898e3f
---
M manifests/misc/monitoring.pp
1 file changed, 16 insertions(+), 3 deletions(-)
Approvals:
Ottomata: Verified; Looks good to me, approved
diff --git a/manifests/misc/monitoring.pp b/manifests/misc/monitoring.pp
index e03ebdc..1dd8b3f 100644
--- a/manifests/misc/monitoring.pp
+++ b/manifests/misc/monitoring.pp
@@ -245,11 +245,11 @@
ganglia::view { "varnishkafka-${title}":
ensure => $ensure,
graphs => [
- # delivery report errors rate
+ # delivery report error rate
{
'host_regex' => $varnishkafka_host_regex,
'metric_regex' => 'kafka.varnishkafka\.kafka_drerr.per_second',
- 'type' => 'stack',
+ 'type' => 'line',
},
# delivery report errors.
# drerr is important, but seems to happen in bursts.
@@ -257,8 +257,15 @@
{
'host_regex' => $varnishkafka_host_regex,
'metric_regex' => 'kafka.varnishkafka\.kafka_drerr$',
- 'type' => 'stack',
+ 'type' => 'line',
},
+ # transaction error rate
+ {
+ 'host_regex' => $varnishkafka_host_regex,
+ 'metric_regex' => 'kafka.varnishkafka\.txerr.per_second',
+ 'type' => 'line',
+ },
+
# round trip time average
{
'host_regex' => $varnishkafka_host_regex,
@@ -305,6 +312,12 @@
'metric_regex' =>
"kafka.rdkafka.topics.${topic_regex}\\.txmsgs.per_second",
'type' => 'stack',
},
+ # varnish client_reqs, show this just for comparision
+ {
+ 'host_regex' => $varnishkafka_host_regex,
+ 'metric_regex' => 'varnish.client_req',
+ 'type' => 'stack',
+ },
],
}
}
--
To view, visit https://gerrit.wikimedia.org/r/110998
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b8b89a88544074401fc7d696961b4b2f6898e3f
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata <o...@wikimedia.org>
Gerrit-Reviewer: Ottomata <o...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
