Cmcmahon has submitted this change and it was merged. Change subject: One scenario step not implemented ......................................................................
One scenario step not implemented Change-Id: Ic1065fdb142eca26583014c85454f7bdaafd4126 --- M features/step_definitions/preferences_editing_steps.rb M features/support/pages/preferences_editing_page.rb 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Jhall: Looks good to me, but someone else must approve Cmcmahon: Looks good to me, approved diff --git a/features/step_definitions/preferences_editing_steps.rb b/features/step_definitions/preferences_editing_steps.rb index 63d8979..a20b344 100644 --- a/features/step_definitions/preferences_editing_steps.rb +++ b/features/step_definitions/preferences_editing_steps.rb @@ -37,6 +37,10 @@ on(PreferencesEditingPage).edit_section_right_click_check_element.when_present.should exist end +Then(/^I can select section editing via edit links$/) do + on(PreferencesEditingPage).edit_section_edit_link_element.when_present.should exist +end + Then(/^I can select show edit toolbar$/) do on(PreferencesEditingPage).show_edit_toolbar_check_element.when_present.should exist end diff --git a/features/support/pages/preferences_editing_page.rb b/features/support/pages/preferences_editing_page.rb index 1b03c2d..cc24299 100644 --- a/features/support/pages/preferences_editing_page.rb +++ b/features/support/pages/preferences_editing_page.rb @@ -17,6 +17,7 @@ select_list(:edit_area_font_style_select, id: "mw-input-wpeditfont") checkbox(:edit_section_double_click_check, id: "mw-input-wpeditondblclick") + checkbox(:edit_section_edit_link, id: "mw-input-wpeditsectiononrightclick") checkbox(:edit_section_right_click_check, id: "mw-input-wpeditsectiononrightclick") checkbox(:enhanced_editing_toolbar_check, id: "mw-input-wpusebetatoolbar") checkbox(:forced_edit_summary_check, id: "mw-input-wpforceeditsummary") -- To view, visit https://gerrit.wikimedia.org/r/110962 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1065fdb142eca26583014c85454f7bdaafd4126 Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Cmcmahon <cmcma...@wikimedia.org> Gerrit-Reviewer: Cmcmahon <cmcma...@wikimedia.org> Gerrit-Reviewer: Jhall <jh...@wikimedia.org> Gerrit-Reviewer: Zfilipin <zfili...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits