Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/111422
Change subject: mw.user: remove #name & #anonymous; deprecate #bucket
......................................................................
mw.user: remove #name & #anonymous; deprecate #bucket
* mw.user#name and mw.user#anonymous have been deprecated in favor of
mw.user#getName and mw.user#isAnon since 1.20. Remove them.
* Deprecate mw.user#bucket. Rationale:
- On the Wikimedia cluster, it is only used by AFT, which is moribund.
- It's too complicated for what it is.
- Its usage leads to a proliferation of large, persistent cookies that
degrade site performance.
- If it were rewritten to be simpler, more generic, and cookie-free, it would
still be an odd fit for the user module.
Change-Id: I3be1cfecb79faee5701708136ede133870b9940d
---
M resources/mediawiki/mediawiki.user.js
1 file changed, 1 insertion(+), 16 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/22/111422/1
diff --git a/resources/mediawiki/mediawiki.user.js
b/resources/mediawiki/mediawiki.user.js
index 78febd2..013c522 100644
--- a/resources/mediawiki/mediawiki.user.js
+++ b/resources/mediawiki/mediawiki.user.js
@@ -89,14 +89,6 @@
},
/**
- * @inheritdoc #getName
- * @deprecated since 1.20 use #getName instead
- */
- name: function () {
- return user.getName();
- },
-
- /**
* Get date user registered, if available
*
* @return {Date|boolean|null} Date user registered, or false
for anonymous users, or
@@ -122,14 +114,6 @@
*/
isAnon: function () {
return user.getName() === null;
- },
-
- /**
- * @inheritdoc #isAnon
- * @deprecated since 1.20 use #isAnon instead
- */
- anonymous: function () {
- return user.isAnon();
},
/**
@@ -169,6 +153,7 @@
* expires: 7
* } );
*
+ * @deprecated since 1.23
* @param {string} key Name of bucket
* @param {Object} options Bucket configuration options
* @param {Object} options.buckets List of
bucket-name/relative-probability pairs (required,
--
To view, visit https://gerrit.wikimedia.org/r/111422
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3be1cfecb79faee5701708136ede133870b9940d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
