Daniel Werner has submitted this change and it was merged. Change subject: Added tests for ItemView ......................................................................
Added tests for ItemView ItemViewTest now also checks for the itemId related class/id values on the outer dom node. Changed EntityObject and all inheriting classes to have a public/static getIdPrefix() instead of a protected one since there is nothing to hide about this and this can also be valuable information in a static context. Change-Id: Ie84ec8bea69382aa9ea98d7000bf29f5e387e8b4 --- M lib/includes/entity/EntityObject.php M lib/includes/item/ItemObject.php M lib/includes/property/PropertyObject.php M lib/includes/query/QueryObject.php M repo/tests/phpunit/includes/ItemViewTest.php 5 files changed, 25 insertions(+), 25 deletions(-) Approvals: Daniel Werner: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/23866 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie84ec8bea69382aa9ea98d7000bf29f5e387e8b4 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner <daniel.wer...@wikimedia.de> Gerrit-Reviewer: Daniel Werner <daniel.wer...@wikimedia.de> Gerrit-Reviewer: John Erling Blad <john.b...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
