Matthias Mullie has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/111649

Change subject: (bug 60906) Truncate content before storing event into DB
......................................................................

(bug 60906) Truncate content before storing event into DB

Because the event_extra column is limited in size, so we don't want
to store too much ;)

Bug: 60906
Change-Id: I0ee10904caaaadecf43c8c5440f901e6888809bb
---
M includes/Notifications/Controller.php
1 file changed, 10 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/49/111649/1

diff --git a/includes/Notifications/Controller.php 
b/includes/Notifications/Controller.php
index fbc834d..c3d1eee 100644
--- a/includes/Notifications/Controller.php
+++ b/includes/Notifications/Controller.php
@@ -91,20 +91,20 @@
                                $replyToPost = $data['reply-to'];
                                $extraData += array(
                                        'reply-to' => $replyToPost->getPostId(),
-                                       'content' => $revision->getContent(),
-                                       'topic-title' => 
$topicRevision->getContent( 'wikitext' ),
+                                       'content' => $this->language->truncate( 
trim( $revision->getContent() ), 200 ),
+                                       'topic-title' => 
$this->language->truncate( trim( $topicRevision->getContent( 'wikitext' ) ), 
200 ),
                                );
                        break;
                        case 'flow-topic-renamed':
                                $extraData += array(
-                                       'old-subject' => 
$topicRevision->getContent( 'wikitext' ),
-                                       'new-subject' => $revision->getContent( 
'wikitext' ),
+                                       'old-subject' => 
$this->language->truncate( trim( $topicRevision->getContent( 'wikitext' ) ), 
200 ),
+                                       'new-subject' => 
$this->language->truncate( trim( $revision->getContent( 'wikitext' ) ), 200 ),
                                );
                        break;
                        case 'flow-post-edited':
                                $extraData += array(
-                                       'content' => $revision->getContent(),
-                                       'topic-title' => 
$topicRevision->getContent( 'wikitext' ),
+                                       'content' => $this->language->truncate( 
trim( $revision->getContent() ), 200 ),
+                                       'topic-title' => 
$this->language->truncate( trim( $topicRevision->getContent( 'wikitext' ) ), 
200 ),
                                );
                        break;
                }
@@ -165,8 +165,8 @@
                                'board-workflow' => $boardWorkflow->getId(),
                                'topic-workflow' => $topicWorkflow->getId(),
                                'post-id' => $firstPost ? 
$firstPost->getRevisionId() : null,
-                               'topic-title' => $topicPost->getContent(),
-                               'content' => $firstPost ? 
$firstPost->getContent() : null,
+                               'topic-title' => $this->language->truncate( 
trim( $topicPost->getContent() ), 200 ),
+                               'content' => $firstPost ? 
$this->language->truncate( trim( $firstPost->getContent() ), 200 ) : null,
                        )
                ) );
 
@@ -209,8 +209,8 @@
                                'type' => 'flow-mention',
                                'title' => $title,
                                'extra' => array(
-                                       'content' => $newRevision ? 
$newRevision->getContent() : null,
-                                       'topic-title' => 
$topicRevision->getContent( 'wikitext' ),
+                                       'content' => $newRevision ? 
$this->language->truncate( trim( $newRevision->getContent() ), 200 ) : null,
+                                       'topic-title' => 
$this->language->truncate( trim( $topicRevision->getContent( 'wikitext' ) ), 
200 ),
                                        'post-id' => $newRevision ? 
$newRevision->getPostId() : null,
                                        'mentioned-users' => $mentionedUsers,
                                        'topic-workflow' => 
$topicWorkflow->getId(),

-- 
To view, visit https://gerrit.wikimedia.org/r/111649
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ee10904caaaadecf43c8c5440f901e6888809bb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to