Matthias Mullie has uploaded a new change for review.
https://gerrit.wikimedia.org/r/111669
Change subject: Don't use .flow-container scoping - tipsy break out of it
......................................................................
Don't use .flow-container scoping - tipsy break out of it
Change-Id: I097736c1fbf5cb0c0e309c50b033d38e1dfd9bc7
---
M modules/mediawiki.ui/styles/agora-override-buttons.less
M modules/mediawiki.ui/styles/agora-override-forms.less
2 files changed, 48 insertions(+), 52 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/69/111669/1
diff --git a/modules/mediawiki.ui/styles/agora-override-buttons.less
b/modules/mediawiki.ui/styles/agora-override-buttons.less
index 05e3522..22d7598 100644
--- a/modules/mediawiki.ui/styles/agora-override-buttons.less
+++ b/modules/mediawiki.ui/styles/agora-override-buttons.less
@@ -3,8 +3,7 @@
@import 'settings/colors.less';
@import 'mixins/buttons.less';
-// .flow-container ensures greater specificity than core rules
-.flow-container .mw-ui-button {
+.mw-ui-button {
font-weight: bold;
border-radius: 3px;
cursor: pointer;
diff --git a/modules/mediawiki.ui/styles/agora-override-forms.less
b/modules/mediawiki.ui/styles/agora-override-forms.less
index 320fbfd..2e9a27a 100644
--- a/modules/mediawiki.ui/styles/agora-override-forms.less
+++ b/modules/mediawiki.ui/styles/agora-override-forms.less
@@ -1,57 +1,54 @@
-// .flow-container ensures greater specificity than core rules
-.flow-container {
- .field-placeholder-styling(@color: #aaa) {
- font-style: italic;
- font-weight: normal;
- color: @color;
+.field-placeholder-styling(@color: #aaa) {
+ font-style: italic;
+ font-weight: normal;
+ color: @color;
+}
+
+.mw-ui-input {
+ border: 1px solid #e6e6e5;
+ color: #6d6e70;
+
+ padding: 6px 10px 6px 15px;
+
+ &:hover {
+ border: 1px solid #c0c0c0;
}
- .mw-ui-input {
- border: 1px solid #e6e6e5;
- color: #6d6e70;
-
- padding: 6px 10px 6px 15px;
-
- &:hover {
- border: 1px solid #c0c0c0;
- }
-
- &:focus {
- box-shadow: 7px 0 0 #347bff inset;
- border: 1px solid #c0c0c0;
- }
-
- /*
- * Duplication because browsers ignore groups containing an
invalid selector.
- * Only one of the below is valid per-browser.
- * @see http://stackoverflow.com/a/2610741
- */
- &::-webkit-input-placeholder { // webkit
- .field-placeholder-styling;
- }
- &::-moz-placeholder { // FF 4-18
- .field-placeholder-styling;
- }
- &:-moz-placeholder { // FF >= 19
- .field-placeholder-styling;
- }
- &:-ms-input-placeholder { // IE >= 10
- .field-placeholder-styling;
- }
+ &:focus {
+ box-shadow: 7px 0 0 #347bff inset;
+ border: 1px solid #c0c0c0;
}
- // make it similar to .mw-ui-button
- a.mw-ui-input,
- input.mw-ui-input {
- display: inline-block;
- vertical-align: middle;
-
- height: 34px;
+ /*
+ * Duplication because browsers ignore groups containing an invalid
selector.
+ * Only one of the below is valid per-browser.
+ * @see http://stackoverflow.com/a/2610741
+ */
+ &::-webkit-input-placeholder { // webkit
+ .field-placeholder-styling;
}
-
- // padding messes up textarea's right scroll bar & bottom right resize
grabber
- // in FF, so hide it as long as it's not necessary
- textarea.mw-ui-input:empty {
- overflow: hidden;
+ &::-moz-placeholder { // FF 4-18
+ .field-placeholder-styling;
}
+ &:-moz-placeholder { // FF >= 19
+ .field-placeholder-styling;
+ }
+ &:-ms-input-placeholder { // IE >= 10
+ .field-placeholder-styling;
+ }
+}
+
+// make it similar to .mw-ui-button
+a.mw-ui-input,
+input.mw-ui-input {
+ display: inline-block;
+ vertical-align: middle;
+
+ height: 34px;
+}
+
+// padding messes up textarea's right scroll bar & bottom right resize grabber
+// in FF, so hide it as long as it's not necessary
+textarea.mw-ui-input:empty {
+ overflow: hidden;
}
--
To view, visit https://gerrit.wikimedia.org/r/111669
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I097736c1fbf5cb0c0e309c50b033d38e1dfd9bc7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
