Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/111684
Change subject: Fix the Qunit tests
......................................................................
Fix the Qunit tests
This is done by removing the wikibase.parsers.QuantityParser.tests
test module as the associated module has been removed with Ic28d1c.
Furthermore a superfluous dependency on mediawiki.tests.qunit.testrunner
has been removed (that module has been removed from core with I21e69f5)
Change-Id: I4dbc078aff926748489a13d4a9e76f0991fce89c
---
M lib/WikibaseLib.hooks.php
M lib/resources/Resources.php
D lib/tests/qunit/formatters/QuantityFormatter.tests.js
3 files changed, 0 insertions(+), 65 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/84/111684/1
diff --git a/lib/WikibaseLib.hooks.php b/lib/WikibaseLib.hooks.php
index 2cf5ab4..6ed976b 100644
--- a/lib/WikibaseLib.hooks.php
+++ b/lib/WikibaseLib.hooks.php
@@ -217,7 +217,6 @@
'util.inherit',
'valueFormatters',
'wikibase.tests.qunit.testrunner',
- 'wikibase.QuantityFormatter',
),
);
@@ -246,20 +245,6 @@
'util.inherit',
'valueParsers.tests',
'wikibase.GlobeCoordinateParser',
- 'wikibase.tests.qunit.testrunner',
- ),
- );
-
- $testModules['qunit']['wikibase.parsers.QuantityParser.tests']
= $moduleBase + array(
- 'scripts' => array(
- 'tests/qunit/wikibase.tests.js',
- 'tests/qunit/parsers/QuantityParser.tests.js',
- ),
- 'dependencies' => array(
- 'dataValues.values',
- 'util.inherit',
- 'valueParsers.tests',
- 'wikibase.QuantityParser',
'wikibase.tests.qunit.testrunner',
),
);
diff --git a/lib/resources/Resources.php b/lib/resources/Resources.php
index 2226720..a155806 100644
--- a/lib/resources/Resources.php
+++ b/lib/resources/Resources.php
@@ -410,7 +410,6 @@
'wikibase.tests.qunit.testrunner' => $moduleTemplate + array(
'scripts' => '../tests/qunit/data/testrunner.js',
'dependencies' => array(
- 'mediawiki.tests.qunit.testrunner',
'wikibase'
),
'position' => 'top'
diff --git a/lib/tests/qunit/formatters/QuantityFormatter.tests.js
b/lib/tests/qunit/formatters/QuantityFormatter.tests.js
deleted file mode 100644
index 9b19811..0000000
--- a/lib/tests/qunit/formatters/QuantityFormatter.tests.js
+++ /dev/null
@@ -1,49 +0,0 @@
-/**
- * @licence GNU GPL v2+
- * @author H. Snater < [email protected] >
- */
-( function( wb, vf, dv, util ) {
- 'use strict';
-
- var PARENT = vf.tests.ValueFormatterTest;
-
- /**
- * Constructor for creating a test object containing tests for the
QuantityFormatter.
- *
- * @constructor
- * @extends valueFormatters.tests.ValueFormatterTest
- * @since 0.1
- */
- wb.tests.QuantityFormatterTest = util.inherit( PARENT, {
-
- /**
- * @see valueFormatters.tests.ValueFormatterTest.getConstructor
- */
- getConstructor: function() {
- return wb.formatters.QuantityFormatter;
- },
-
- /**
- * @see
valueFormatters.tests.ValueFormatterTest.getFormatArguments
- */
- getFormatArguments: function() {
- return [
- [
- new dv.QuantityValue(
- new dv.DecimalValue( 5 ),
- 'some unit',
- new dv.DecimalValue( 6 ),
- new dv.DecimalValue( 4 )
- ),
- '5±1some unit'
- ]
- ];
- }
-
- } );
-
- var test = new wb.tests.QuantityFormatterTest();
-
- test.runTests( 'wikibase.formatters.QuantityFormatter' );
-
-}( wikibase, valueFormatters, dataValues, util ) );
--
To view, visit https://gerrit.wikimedia.org/r/111684
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4dbc078aff926748489a13d4a9e76f0991fce89c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
