Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/111821
Change subject: Undefined variables first in selectNodes
......................................................................
Undefined variables first in selectNodes
Change-Id: I514c4fe2491c24dfc1037bbeee173de12efd8f24
---
M modules/ve/ve.Document.js
1 file changed, 6 insertions(+), 18 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/21/111821/1
diff --git a/modules/ve/ve.Document.js b/modules/ve/ve.Document.js
index 38aea77..d2565ab 100644
--- a/modules/ve/ve.Document.js
+++ b/modules/ve/ve.Document.js
@@ -73,7 +73,11 @@
* @throws {Error} Failed to select any nodes
*/
ve.Document.prototype.selectNodes = function ( range, mode ) {
- var doc = this.getDocumentNode(),
+ var node, prevNode, nextNode, left, right, parentFrame,
+ startInside, endInside, startBetween, endBetween,
+ nodeRange, parentRange,
+ isWrapped, isPrevUnwrapped, isNextUnwrapped, isEmptyBranch,
+ doc = this.getDocumentNode(),
retval = [],
start = range.start,
end = range.end,
@@ -86,24 +90,8 @@
// First offset inside node
'startOffset': 0
} ],
- node,
- prevNode,
- nextNode,
- left,
- right,
currentFrame = stack[0],
- parentFrame,
- startInside,
- endInside,
- startBetween,
- endBetween,
- startFound = false,
- nodeRange,
- parentRange,
- isWrapped,
- isPrevUnwrapped,
- isNextUnwrapped,
- isEmptyBranch;
+ startFound = false;
mode = mode || 'leaves';
if ( mode !== 'leaves' && mode !== 'branches' && mode !== 'covered' &&
mode !== 'siblings' ) {
--
To view, visit https://gerrit.wikimedia.org/r/111821
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I514c4fe2491c24dfc1037bbeee173de12efd8f24
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
