BryanDavis has uploaded a new change for review.
https://gerrit.wikimedia.org/r/111917
Change subject: Send Vary header on http to http redirect
......................................................................
Send Vary header on http to http redirect
Work around a "feature" in apache that strips headers from redirect
responses by setting an environment variable and adding the Vary header
later in the response cycle. Without this information frontend Varnish
caches will cache the 30x response independent of request protocol and
cause redirect loops.
Bug: 60822
Change-Id: I83cef4b4d1c956ede13b9e124a046015962d7458
---
M modules/contint/files/apache/doc.wikimedia.org
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/17/111917/1
diff --git a/modules/contint/files/apache/doc.wikimedia.org
b/modules/contint/files/apache/doc.wikimedia.org
index feeecc4..ea1577d 100644
--- a/modules/contint/files/apache/doc.wikimedia.org
+++ b/modules/contint/files/apache/doc.wikimedia.org
@@ -23,9 +23,12 @@
# Force any request to HTTPS if not passed via https (misc web varnish)
+ # Use Env flag + Header hack to work around apache internal issue that
+ # strips headers when creating a redirect response.
RewriteEngine On
RewriteCond %{HTTP:X-Forwarded-Proto} !https
- RewriteRule (.) https://doc.wikimedia.org%{REQUEST_URI} [R=301]
+ RewriteRule (.) https://doc.wikimedia.org%{REQUEST_URI}
[R=301,E=ProtoRedirect]
+ Header always merge Vary X-Forwarded-Proto env=ProtoRedirect
DocumentRoot /srv/org/wikimedia/doc
@@ -33,4 +36,4 @@
RewriteEngine On
RewriteRule ^/favicon\.ico$ /favicon.php [L]
-</VirtualHost>
\ No newline at end of file
+</VirtualHost>
--
To view, visit https://gerrit.wikimedia.org/r/111917
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83cef4b4d1c956ede13b9e124a046015962d7458
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BryanDavis <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
