jenkins-bot has submitted this change and it was merged. Change subject: Get rid of hyphenation ......................................................................
Get rid of hyphenation What hyphenation does is break up words (with a hyphen) that are known to the dictionary and are about to go out of the container. E.g. |This is some text and my con-| |tainer ends where I added the| |pipe | Hypenation will split up all words near the end of the container length. I would prefer to actually have it like this, though - without hyphens: |This is some text and my | |container end where I added | |the pipe | I don't think it makes sense to break up every possible word that can be broken up; I think we only need to break up words that, in their entirety are too long for the container, like: |longwordlongwordlongwordlongw| |ordlongword | Yes, this will not have hyphentation, but to be fair, words over 800px are probably not words that would be in the dictionary and would get hyphenation. So in that case it doesn't really add much to have the hyphenation. Change-Id: I15fe067505c266aa18ae92b93f69b7b5f8afadd6 --- M modules/base/styles/mixins/wordbreak.less 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: EBernhardson: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/base/styles/mixins/wordbreak.less b/modules/base/styles/mixins/wordbreak.less index c550b6e..7f0c162 100644 --- a/modules/base/styles/mixins/wordbreak.less +++ b/modules/base/styles/mixins/wordbreak.less @@ -3,8 +3,4 @@ /* Non standard for webkit */ word-break: break-word; - - -webkit-hyphens: auto; - -moz-hyphens: auto; - hyphens: auto; } -- To view, visit https://gerrit.wikimedia.org/r/111958 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15fe067505c266aa18ae92b93f69b7b5f8afadd6 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Flow Gerrit-Branch: master Gerrit-Owner: Matthias Mullie <mmul...@wikimedia.org> Gerrit-Reviewer: EBernhardson <ebernhard...@wikimedia.org> Gerrit-Reviewer: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: Matthias Mullie <mmul...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits