Trevor Parscal has uploaded a new change for review. https://gerrit.wikimedia.org/r/112146
Change subject: [WIP] Split out the guts of MediaEditDialog into separate page classes ...................................................................... [WIP] Split out the guts of MediaEditDialog into separate page classes These are the skeleton classes, the real work needs doing still. Change-Id: Ideb3d9728b80b6ce9addf4ea8b1694aedf461d36 --- A modules/ve-mw/ui/pages/ve.ui.MWAdvancedMediaSettingsPage.js A modules/ve-mw/ui/pages/ve.ui.MWGeneralMediaSettingsPage.js 2 files changed, 126 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/46/112146/1 diff --git a/modules/ve-mw/ui/pages/ve.ui.MWAdvancedMediaSettingsPage.js b/modules/ve-mw/ui/pages/ve.ui.MWAdvancedMediaSettingsPage.js new file mode 100644 index 0000000..b272396 --- /dev/null +++ b/modules/ve-mw/ui/pages/ve.ui.MWAdvancedMediaSettingsPage.js @@ -0,0 +1,63 @@ +/*! + * VisualEditor user interface MWAdvancedMediaSettingsPage class. + * + * @copyright 2011-2014 VisualEditor Team and others; see AUTHORS.txt + * @license The MIT License (MIT); see LICENSE.txt + */ + +/** + * MediaWiki media dialog advanced settings page. + * + * @class + * @extends OO.ui.PageLayout + * + * @constructor + * @param {ve.ui.Surface} surface Surface being worked on + * @param {string} name Unique symbolic name of page + * @param {Object} [config] Configuration options + */ +ve.ui.MWAdvancedMediaSettingsPage = function VeUiMWAdvancedMediaSettingsPage( surface, name, config ) { + // Parent constructor + OO.ui.PageLayout.call( this, name, config ); + + // Initialization + // TODO: Append content: this.$element.append( ... ); +}; + +/* Inheritance */ + +OO.inheritClass( ve.ui.MWAdvancedMediaSettingsPage, OO.ui.PageLayout ); + +/* Methods */ + +/** + * @inheritdoc + */ +ve.ui.MWAdvancedMediaSettingsPage.prototype.setOutlineItem = function ( outlineItem ) { + // Parent method + OO.ui.PageLayout.prototype.setOutlineItem.call( this, outlineItem ); + + this.outlineItem + .setIcon( 'parameter' ) + .setLabel( ve.msg( 'visualeditor-dialog-media-page-advanced' ) ); +}; + +/** + * Setup settings page. + * + * @param {Object} [data] Dialog setup data + */ +ve.ui.MWAdvancedMediaSettingsPage.prototype.setup = function () { + +}; + +/** + * Tear down settings page. + * + * @param {Object} [data] Dialog tear down data + */ +ve.ui.MWAdvancedMediaSettingsPage.prototype.teardown = function ( data ) { + // Data initialization + data = data || {}; + +}; diff --git a/modules/ve-mw/ui/pages/ve.ui.MWGeneralMediaSettingsPage.js b/modules/ve-mw/ui/pages/ve.ui.MWGeneralMediaSettingsPage.js new file mode 100644 index 0000000..618559f --- /dev/null +++ b/modules/ve-mw/ui/pages/ve.ui.MWGeneralMediaSettingsPage.js @@ -0,0 +1,63 @@ +/*! + * VisualEditor user interface MWGeneralMediaSettingsPage class. + * + * @copyright 2011-2014 VisualEditor Team and others; see AUTHORS.txt + * @license The MIT License (MIT); see LICENSE.txt + */ + +/** + * MediaWiki media dialog General settings page. + * + * @class + * @extends OO.ui.PageLayout + * + * @constructor + * @param {ve.ui.Surface} surface Surface being worked on + * @param {string} name Unique symbolic name of page + * @param {Object} [config] Configuration options + */ +ve.ui.MWGeneralMediaSettingsPage = function VeUiMWGeneralMediaSettingsPage( surface, name, config ) { + // Parent constructor + OO.ui.PageLayout.call( this, name, config ); + + // Initialization + // TODO: Append content: this.$element.append( ... ); +}; + +/* Inheritance */ + +OO.inheritClass( ve.ui.MWGeneralMediaSettingsPage, OO.ui.PageLayout ); + +/* Methods */ + +/** + * @inheritdoc + */ +ve.ui.MWGeneralMediaSettingsPage.prototype.setOutlineItem = function ( outlineItem ) { + // Parent method + OO.ui.PageLayout.prototype.setOutlineItem.call( this, outlineItem ); + + this.outlineItem + .setIcon( 'parameter' ) + .setLabel( ve.msg( 'visualeditor-dialog-media-page-general' ) ); +}; + +/** + * Setup settings page. + * + * @param {Object} [data] Dialog setup data + */ +ve.ui.MWGeneralMediaSettingsPage.prototype.setup = function () { + +}; + +/** + * Tear down settings page. + * + * @param {Object} [data] Dialog tear down data + */ +ve.ui.MWGeneralMediaSettingsPage.prototype.teardown = function ( data ) { + // Data initialization + data = data || {}; + +}; -- To view, visit https://gerrit.wikimedia.org/r/112146 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ideb3d9728b80b6ce9addf4ea8b1694aedf461d36 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Trevor Parscal <tpars...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits