[MediaWiki-commits] [Gerrit] Add hook SkinMinerva::getDefaultModules - change (mediawiki...MobileFrontend)

[Jdlrobson (Code Review)]

Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/112155

Change subject: Add hook SkinMinerva::getDefaultModules
......................................................................

Add hook SkinMinerva::getDefaultModules

To allow Zero and other extensions to tweak default
modules before they are served.

Created getModeDefaultModules so that hook runs after beta
and alpha modules have been added.

Change-Id: I8addf6b0aba64c95944653656b9a9addee218e93
---
M includes/skins/SkinMinerva.php
M includes/skins/SkinMinervaAlpha.php
M includes/skins/SkinMinervaBeta.php
3 files changed, 10 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/55/112155/1

diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index cf38926..51a3179 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -632,7 +632,7 @@
                return $vars;
        }
 
-       public function getDefaultModules() {
+       protected function getModeDefaultModules() {
                $modules = parent::getDefaultModules();
                // flush unnecessary modules
                $modules['content'] = array();
@@ -676,6 +676,11 @@
                                );
                        }
                }
+       }
+
+       public function getDefaultModules() {
+               $modules = $this->getModeDefaultModules();
+               wfRunHooks( 'SkinMinervaGetDefaultModules', array( &$modules ) 
);
                return $modules;
        }
 
diff --git a/includes/skins/SkinMinervaAlpha.php 
b/includes/skins/SkinMinervaAlpha.php
index e49a8b5..dac0eec 100644
--- a/includes/skins/SkinMinervaAlpha.php
+++ b/includes/skins/SkinMinervaAlpha.php
@@ -8,8 +8,8 @@
                return wfMessage( 'mobile-frontend-placeholder-alpha' )->text();
        }
 
-       public function getDefaultModules() {
-               $modules = parent::getDefaultModules();
+       protected function getModeDefaultModules() {
+               $modules = parent::getModeDefaultModules();
                $modules['alpha'] = array( 'mobile.alpha' );
                return $modules;
        }
diff --git a/includes/skins/SkinMinervaBeta.php 
b/includes/skins/SkinMinervaBeta.php
index 4b0ebba..15364bb 100644
--- a/includes/skins/SkinMinervaBeta.php
+++ b/includes/skins/SkinMinervaBeta.php
@@ -55,8 +55,8 @@
                return $vars;
        }
 
-       public function getDefaultModules() {
-               $modules = parent::getDefaultModules();
+       protected function getModeDefaultModules() {
+               $modules = parent::getModeDefaultModules();
                $modules['mobile'][] = 'mobile.head.beta';
                $modules['beta'] = array( 'mobile.beta' );
                $modules['beta'][] = 'mobile.geonotahack';

-- 
To view, visit https://gerrit.wikimedia.org/r/112155
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8addf6b0aba64c95944653656b9a9addee218e93
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits