Xqt has uploaded a new change for review.
https://gerrit.wikimedia.org/r/112329
Change subject: Use site object from site generator directly sorted by dbname
......................................................................
Use site object from site generator directly sorted by dbname
Since we have the site objects now, we use them directly without
re-creating them with it's language code. Also we sort the sites
by their dbnames.
Change-Id: If5b4f155a04665f2c32cf11931a13102d704d42a
---
M scripts/featured.py
1 file changed, 9 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core
refs/changes/29/112329/1
diff --git a/scripts/featured.py b/scripts/featured.py
index 5277e53..d8cbedf 100644
--- a/scripts/featured.py
+++ b/scripts/featured.py
@@ -240,7 +240,7 @@
if not self.tasks:
self.tasks = ['featured']
- def itercode(self, task):
+ def itersites(self, task):
""" generator for site codes to be processed """
def _generator():
@@ -252,7 +252,7 @@
item_no = former_name['wikidata'][1]
dp = pywikibot.ItemPage(self.site.data_repository(), item_no)
dp.get()
- for key in dp.sitelinks.keys():
+ for key in sorted(dp.sitelinks.keys()):
try:
site = self.site.fromDBName(key)
except pywikibot.NoSuchSite:
@@ -274,10 +274,10 @@
start = ""
if not end:
end = "zzzzzzz"
- return (code for code in generator
- if code >= start and code <= end)
+ return (site for site in generator
+ if site.code >= start and site.code <= end)
else:
- return (code for code in generator if code in fromlang)
+ return (site for site in generator if site.code in fromlang)
else:
pywikibot.warning(u'No sites given to verify %s articles.\n'
u'Please use -fromlang: or fromall option\n'
@@ -329,18 +329,17 @@
return
self.readcache(task)
- for code in self.itercode(task):
+ for site in self.itersites(task):
try:
- self.treat(code, task)
+ self.treat(site, task)
except KeyboardInterrupt:
pywikibot.output('\nQuitting %s treat...' % task)
break
self.writecache()
- def treat(self, code, process):
- fromsite = pywikibot.Site(code)
+ def treat(self, fromsite, task):
if fromsite != self.site:
- self.featuredWithInterwiki(fromsite, process)
+ self.featuredWithInterwiki(fromsite, task)
def featuredArticles(self, site, task, cache):
code = site.lang
--
To view, visit https://gerrit.wikimedia.org/r/112329
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If5b4f155a04665f2c32cf11931a13102d704d42a
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <i...@gno.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
