Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/112349
Change subject: Use hasOwnProperty() instead of !== undefined
......................................................................
Use hasOwnProperty() instead of !== undefined
This prevents conflicts with predefined object methods.
Change-Id: I3804d3c7c1439d0818a01c03b5fb5b0328c953a4
---
M repo/resources/wikibase.ui.initTermBox.js
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/49/112349/1
diff --git a/repo/resources/wikibase.ui.initTermBox.js
b/repo/resources/wikibase.ui.initTermBox.js
index 79ced99..0093a3f 100644
--- a/repo/resources/wikibase.ui.initTermBox.js
+++ b/repo/resources/wikibase.ui.initTermBox.js
@@ -131,8 +131,8 @@
languageCode,
alternatingClass,
$.uls.data.getAutonym( languageCode ),
- ( labels[languageCode] !== undefined ) ?
labels[languageCode] : '',
- ( descriptions[languageCode] !== undefined ) ?
descriptions[languageCode] : '',
+ labels.hasOwnProperty( languageCode ) ?
labels[languageCode] : '',
+ descriptions.hasOwnProperty( languageCode ) ?
descriptions[languageCode] : '',
'',
'',
'',
--
To view, visit https://gerrit.wikimedia.org/r/112349
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3804d3c7c1439d0818a01c03b5fb5b0328c953a4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <gerritpatchuploa...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
