Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/112407
Change subject: Fix some more places broken by wgDebugToolbar
......................................................................
Fix some more places broken by wgDebugToolbar
See I907ef6fc
Change-Id: Ie44faa15629ebba834cb08ba6247ff3beaabd0ae
---
M modules/ve-mw/ui/widgets/ve.ui.MWCategoryInputWidget.js
M modules/ve-mw/ui/widgets/ve.ui.MWTitleInputWidget.js
2 files changed, 6 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/07/112407/1
diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWCategoryInputWidget.js
b/modules/ve-mw/ui/widgets/ve.ui.MWCategoryInputWidget.js
index f71c340..5ecff67 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWCategoryInputWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWCategoryInputWidget.js
@@ -70,14 +70,12 @@
*/
ve.ui.MWCategoryInputWidget.prototype.getLookupCacheItemFromData = function (
data ) {
var i, len, title, result = [];
- if ( ve.isArray( data ) && data.length ) {
- for ( i = 0, len = data[1].length; i < len; i++ ) {
- title = mw.Title.newFromText( data[1][i] );
- if ( title ) {
- result.push( title.getMainText() );
- }
- // If the received title isn't valid, just ignore it
+ for ( i = 0, len = data[1].length; i < len; i++ ) {
+ title = mw.Title.newFromText( data[1][i] );
+ if ( title ) {
+ result.push( title.getMainText() );
}
+ // If the received title isn't valid, just ignore it
}
return result;
};
diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWTitleInputWidget.js
b/modules/ve-mw/ui/widgets/ve.ui.MWTitleInputWidget.js
index cd5bda8..759a399 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWTitleInputWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWTitleInputWidget.js
@@ -92,7 +92,7 @@
* @param {Mixed} data Response from server
*/
ve.ui.MWTitleInputWidget.prototype.getLookupCacheItemFromData = function (
data ) {
- return ve.isArray( data ) && data.length ? data[1] : [];
+ return data[1] || [];
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/112407
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie44faa15629ebba834cb08ba6247ff3beaabd0ae
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <kren...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
