[MediaWiki-commits] [Gerrit] Fix remaining strings not participating in live language pre... - change (mediawiki...UniversalLanguageSelector)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Fix remaining strings not participating in live language preview
......................................................................


Fix remaining strings not participating in live language preview

Change-Id: Id2dc9279e4bfae499a6e8b00a34a74c5505512b2
---
M resources/js/ext.uls.displaysettings.js
M resources/js/ext.uls.inputsettings.js
M resources/js/ext.uls.languagesettings.js
3 files changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Santhosh: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/js/ext.uls.displaysettings.js 
b/resources/js/ext.uls.displaysettings.js
index db70e41..b988fe6 100644
--- a/resources/js/ext.uls.displaysettings.js
+++ b/resources/js/ext.uls.displaysettings.js
@@ -81,8 +81,8 @@
                + '</div>'; // End font settings section
 
        function DisplaySettings( $parent ) {
-               this.name = $.i18n( 'ext-uls-display-settings-title-short' );
-               this.description = $.i18n( 'ext-uls-display-settings-desc' );
+               this.nameI18n = 'ext-uls-display-settings-title-short';
+               this.descriptionI18n = 'ext-uls-display-settings-desc';
                this.$template = $( template );
                this.uiLanguage = this.getUILanguage();
                this.contentLanguage = this.getContentLanguage();
diff --git a/resources/js/ext.uls.inputsettings.js 
b/resources/js/ext.uls.inputsettings.js
index 11e592f..c75ab99 100644
--- a/resources/js/ext.uls.inputsettings.js
+++ b/resources/js/ext.uls.inputsettings.js
@@ -56,8 +56,8 @@
                + '</div>';
 
        function InputSettings( $parent ) {
-               this.name = $.i18n( 'ext-uls-input-settings-title-short' );
-               this.description = $.i18n( 'ext-uls-input-settings-desc' );
+               this.nameI18n = 'ext-uls-input-settings-title-short';
+               this.descriptionI18n = 'ext-uls-input-settings-desc';
                this.$template = $( template );
                this.uiLanguage = this.getInterfaceLanguage();
                this.contentLanguage = this.getContentLanguage();
diff --git a/resources/js/ext.uls.languagesettings.js 
b/resources/js/ext.uls.languagesettings.js
index b82ace4..8bf50db 100644
--- a/resources/js/ext.uls.languagesettings.js
+++ b/resources/js/ext.uls.languagesettings.js
@@ -126,10 +126,10 @@
 
                        $settingsTitle = $( '<div>' )
                                .addClass( 'settings-title' )
-                               .text( module.name );
+                               .attr( 'data-i18n', module.nameI18n );
                        $settingsText = $( '<span>' )
                                .addClass( 'settings-text' )
-                               .text( module.description );
+                               .attr( 'data-i18n', module.descriptionI18n );
                        $settingsLink = $( '<div>' )
                                .addClass( moduleName + '-settings-block 
menu-section' )
                                .prop( 'id', moduleName + '-panel-trigger' )

-- 
To view, visit https://gerrit.wikimedia.org/r/110681
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id2dc9279e4bfae499a6e8b00a34a74c5505512b2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: Santhosh <santhosh.thottin...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits