Ottomata has submitted this change and it was merged. Change subject: File outputs were erroneously closed in outputs_check ......................................................................
File outputs were erroneously closed in outputs_check Change-Id: I8383ad57ad66314acf8658288c481d249ed9d834 --- M output.c 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Ottomata: Verified; Looks good to me, approved diff --git a/output.c b/output.c index 8e9def7..4875599 100644 --- a/output.c +++ b/output.c @@ -356,10 +356,11 @@ /* Already open */ if (o->o_fd != -1) { - if (o->o_pipe.status != -1) - output_close(o, LOG_WARNING, - exec_exitstatus(o->o_pipe.status)); - continue; + if (o->o_type == OUTPUT_PIPE && + o->o_pipe.status != -1) + output_close(o, LOG_WARNING, + exec_exitstatus(o->o_pipe.status)); + continue; } /* Last open failed: back off */ -- To view, visit https://gerrit.wikimedia.org/r/112467 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8383ad57ad66314acf8658288c481d249ed9d834 Gerrit-PatchSet: 1 Gerrit-Project: analytics/kafkatee Gerrit-Branch: master Gerrit-Owner: Edenhill <mag...@edenhill.se> Gerrit-Reviewer: Ottomata <o...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits