Mooeypoo has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/112491

Change subject: Make MWMediaSearchDialog not ignore empty scriptDirUrl
......................................................................

Make MWMediaSearchDialog not ignore empty scriptDirUrl

For wikis that are installed in root directory, the API parameter
'scriptDirUrl' is an empty string. This change makes sure it is not
ignored.

Change-Id: Ib58adf76c184c32c0cdbb9dba31db1e4028fa383
---
M modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/91/112491/1

diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js 
b/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
index f0d5c03..5590ff6 100755
--- a/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
@@ -107,7 +107,7 @@
                source = this.sources[i];
                // If we don't have either 'apiurl' or 'scriptDirUrl'
                // the source is invalid, and we will skip it
-               if ( source.apiurl || source.scriptDirUrl ) {
+               if ( source.apiurl || source.scriptDirUrl !== undefined ) {
                        if ( source.request ) {
                                source.request.abort();
                        }

-- 
To view, visit https://gerrit.wikimedia.org/r/112491
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib58adf76c184c32c0cdbb9dba31db1e4028fa383
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to