jenkins-bot has submitted this change and it was merged.
Change subject: Remove gradients, minor cleanup
......................................................................
Remove gradients, minor cleanup
Fix formatting and grammar and duplicate selectors. Due to the
duplication, one of the gradients was not taking effect previously
anyway. Also, the new core buttons do not use gradients, so this
moves us a step closer.
Change-Id: Ifc69ee714be897f02964c82e54b765d48849a45f
---
M resources/ext.gettingstarted.return.css
1 file changed, 8 insertions(+), 22 deletions(-)
Approvals:
Pginer: Looks good to me, but someone else must approve
Swalling: Looks good to me, but someone else must approve
Phuedx: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/ext.gettingstarted.return.css
b/resources/ext.gettingstarted.return.css
index ed4ed39..5db9604 100644
--- a/resources/ext.gettingstarted.return.css
+++ b/resources/ext.gettingstarted.return.css
@@ -15,7 +15,7 @@
#mw-gettingstarted-editable-main-edit-page {
/*
Can use min-width here to avoid bad wrapping (e.g. text
- different on line from icon), since it is not intended
+ is on a different line from icon), since it is not intended
to wrap.
*/
min-width: 210px;
@@ -100,28 +100,14 @@
}
.mw-ui-button.mw-gettingstarted-cta-secondary:hover {
- /*
- TODO (mattflaschen, 2013-10-03): This is inconsistent with
- normal mw.ui secondary buttons. We should make them match.
- */
- background-color: #fbfbfb;
- border-color: #cccccc;
- background-image: -webkit-gradient(linear, 50% 0%, 50% 100%,
color-stop(0%, #fbfbfb), color-stop(100%, #f8f8f8));
- background-image: -webkit-linear-gradient(top, #fbfbfb, #f8f8f8);
- background-image: -moz-linear-gradient(top, #fbfbfb, #f8f8f8);
- background-image: -o-linear-gradient(top, #fbfbfb, #f8f8f8);
- background-image: linear-gradient(top, #fbfbfb, #f8f8f8);
+ /*
+ TODO (mattflaschen, 2013-10-03): This is inconsistent with
+ normal mw.ui secondary buttons. We should make them match.
+ */
+ background-color: #fbfbfb;
+ border-color: #cccccc;
}
.mw-ui-button.mw-gettingstarted-cta-secondary {
- background-image: -webkit-gradient(linear, 50% 0%, 50% 100%,
color-stop(0%, #f8f8f8), color-stop(100%, #f0f0f0));
- background-image: -webkit-linear-gradient(top, #f8f8f8, #f0f0f0);
- background-image: -moz-linear-gradient(top, #f8f8f8, #f0f0f0);
- background-image: -o-linear-gradient(top, #f8f8f8, #f0f0f0);
- background-image: linear-gradient(top, #f8f8f8, #f0f0f0);
- }
-
-.mw-ui-button.mw-gettingstarted-cta-secondary {
- background-image: none;
background-color: #F5F5F5;
border: 1px solid #D3D3D3;
color: #444444;
@@ -149,4 +135,4 @@
clear: both;
margin-top: 20px;
font-size: 0.8em;
-}
\ No newline at end of file
+}
--
To view, visit https://gerrit.wikimedia.org/r/111144
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc69ee714be897f02964c82e54b765d48849a45f
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: Pginer <pgi...@wikimedia.org>
Gerrit-Reviewer: Phuedx <g...@samsmith.io>
Gerrit-Reviewer: Swalling <swall...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
