KartikMistry has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/112664

Change subject: Check if directory exists in a better manner
......................................................................

Check if directory exists in a better manner

 * This avoids warnings like: line 8: cd: /tmp/jquery.ime:
   No such file or directory.
 * Formatting fixes.

Change-Id: Icbc3f6f80314cae3ea9b5dfdc3e66c59af225621
---
M scripts/update-jquery-i18n.sh
M scripts/update-jquery-ime.sh
M scripts/update-jquery-uls.sh
M scripts/update-jquery-webfonts.sh
4 files changed, 32 insertions(+), 4 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector 
refs/changes/64/112664/1

diff --git a/scripts/update-jquery-i18n.sh b/scripts/update-jquery-i18n.sh
index 4e53c18..321e124 100755
--- a/scripts/update-jquery-i18n.sh
+++ b/scripts/update-jquery-i18n.sh
@@ -4,7 +4,14 @@
 CLONEDIR="/tmp/jquery.i18n";
 HERE=`pwd`;
 UPSTREAM="https://github.com/wikimedia/jquery.i18n.git";;
+
 echo -e "Getting latest jquery.i18n from $UPSTREAM\n";
-if cd $CLONEDIR; then git pull; else git clone $UPSTREAM $CLONEDIR; fi
+
+if [ -d $CLONEDIR ]; then
+    git pull;
+else
+    git clone $UPSTREAM $CLONEDIR;
+fi
+
 cd $HERE;
 cp -rf $CLONEDIR/src/* $DEST
diff --git a/scripts/update-jquery-ime.sh b/scripts/update-jquery-ime.sh
index c39f642..1c01347 100755
--- a/scripts/update-jquery-ime.sh
+++ b/scripts/update-jquery-ime.sh
@@ -4,8 +4,15 @@
 CLONEDIR="/tmp/jquery.ime";
 HERE=`pwd`;
 UPSTREAM="https://github.com/wikimedia/jquery.ime.git";;
+
 echo -e "Getting latest jquery.ime from $UPSTREAM\n";
-if cd $CLONEDIR; then git pull; else git clone $UPSTREAM $CLONEDIR; fi
+
+if [ -d $CLONEDIR ]; then
+    git pull;
+else
+    git clone $UPSTREAM $CLONEDIR;
+fi
+
 cd $CLONEDIR;
 npm install;
 grunt copy concat;
diff --git a/scripts/update-jquery-uls.sh b/scripts/update-jquery-uls.sh
index bff030b..bf6282c 100755
--- a/scripts/update-jquery-uls.sh
+++ b/scripts/update-jquery-uls.sh
@@ -4,7 +4,14 @@
 CLONEDIR="/tmp/jquery.uls";
 HERE=`pwd`;
 UPSTREAM="https://github.com/wikimedia/jquery.uls.git";;
+
 echo -e "Getting latest jquery.uls from $UPSTREAM\n";
-if cd $CLONEDIR; then git pull; else git clone $UPSTREAM $CLONEDIR; fi
+
+if [ -d $CLONEDIR ]; then 
+    git pull;
+else
+    git clone $UPSTREAM $CLONEDIR;
+fi
+
 cd $HERE;
 cp -rf $CLONEDIR/{images,css,src,i18n} $DEST
diff --git a/scripts/update-jquery-webfonts.sh 
b/scripts/update-jquery-webfonts.sh
index 32f4818..c2c1e65 100755
--- a/scripts/update-jquery-webfonts.sh
+++ b/scripts/update-jquery-webfonts.sh
@@ -4,7 +4,14 @@
 CLONEDIR="/tmp/jquery.webfonts";
 HERE=`pwd`;
 UPSTREAM="https://github.com/wikimedia/jquery.webfonts.git";;
+
 echo -e "Getting latest jquery.webfonts from $UPSTREAM\n";
-if cd $CLONEDIR; then git pull; else git clone $UPSTREAM $CLONEDIR; fi
+
+if [ -d $CLONEDIR ]; then
+    git pull;
+else
+    git clone $UPSTREAM $CLONEDIR;
+fi
+
 cd $HERE;
 cp -rf $CLONEDIR/src/* $DEST

-- 
To view, visit https://gerrit.wikimedia.org/r/112664
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icbc3f6f80314cae3ea9b5dfdc3e66c59af225621
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: KartikMistry <kartik.mis...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to