JGonera has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/112822

Change subject: Fix missing overlay header in RTL languages on Android 2.3
......................................................................

Fix missing overlay header in RTL languages on Android 2.3

Because of weird CSS bugs Android 2.3 would not show the header in
overlays.

Change-Id: Iaae449deb84ffbcfb9a69e81c4fefe9fae96c3dc
---
M less/common/OverlayNew.less
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/22/112822/1

diff --git a/less/common/OverlayNew.less b/less/common/OverlayNew.less
index 9394669..2731b11 100644
--- a/less/common/OverlayNew.less
+++ b/less/common/OverlayNew.less
@@ -207,8 +207,12 @@
                white-space: nowrap;
 
                &.position-fixed {
-                       // both top and left required for Android 2
+                       // both top and left required for Android 2 for the 
element to be visible
                        left: 0;
+                       // the following right: 0 is converted to left: 0 for 
RTL languages
+                       // (for unknown reasons left: 0 is mandatory in Android 
2 for the
+                       // element to be visible, right: 0 doesn't work)
+                       right: 0;
                        // prevent .page-list overlaping the header when 
scrolling
                        z-index: 5;
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/112822
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaae449deb84ffbcfb9a69e81c4fefe9fae96c3dc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <jgon...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to