Brion VIBBER has submitted this change and it was merged.
Change subject: Make 'Done' perform login action
......................................................................
Make 'Done' perform login action
Bug: 61261
Change-Id: I461696aeddef1e717c3e831b3879c804bdba0a93
---
M wikipedia/res/layout/activity_login.xml
M wikipedia/src/main/java/org/wikipedia/login/LoginActivity.java
2 files changed, 16 insertions(+), 4 deletions(-)
Approvals:
Brion VIBBER: Verified; Looks good to me, approved
diff --git a/wikipedia/res/layout/activity_login.xml
b/wikipedia/res/layout/activity_login.xml
index 3cc3167..a5ed462 100644
--- a/wikipedia/res/layout/activity_login.xml
+++ b/wikipedia/res/layout/activity_login.xml
@@ -13,6 +13,7 @@
style="?android:textAppearanceMedium"
android:hint="@string/login_username_hint"
android:inputType="textNoSuggestions"
+ android:singleLine="true"
/>
<org.wikipedia.styledviews.StylizedEditText
android:id="@+id/login_password_text"
@@ -21,6 +22,7 @@
android:inputType="textPassword"
style="?android:textAppearanceMedium"
android:hint="@string/login_password_hint"
+ android:imeOptions="actionDone"
/>
<org.wikipedia.styledviews.StyledCheckBox
android:id="@+id/login_show_password"
diff --git a/wikipedia/src/main/java/org/wikipedia/login/LoginActivity.java
b/wikipedia/src/main/java/org/wikipedia/login/LoginActivity.java
index 5dde0bd..8ce2dc1 100644
--- a/wikipedia/src/main/java/org/wikipedia/login/LoginActivity.java
+++ b/wikipedia/src/main/java/org/wikipedia/login/LoginActivity.java
@@ -8,12 +8,11 @@
import android.text.InputType;
import android.text.TextWatcher;
import android.util.Log;
+import android.view.KeyEvent;
import android.view.Menu;
import android.view.MenuItem;
-import android.widget.CheckBox;
-import android.widget.CompoundButton;
-import android.widget.EditText;
-import android.widget.Toast;
+import android.view.inputmethod.EditorInfo;
+import android.widget.*;
import de.keyboardsurfer.android.widget.crouton.Crouton;
import de.keyboardsurfer.android.widget.crouton.Style;
import org.wikipedia.R;
@@ -58,6 +57,17 @@
usernameText.addTextChangedListener(enableActionWhenNonEmptyWatcher);
passwordText.addTextChangedListener(enableActionWhenNonEmptyWatcher);
+ passwordText.setOnEditorActionListener(new
TextView.OnEditorActionListener() {
+ @Override
+ public boolean onEditorAction(TextView textView, int actionId,
KeyEvent keyEvent) {
+ if (actionId == EditorInfo.IME_ACTION_DONE) {
+ doLogin();
+ return true;
+ }
+ return false;
+ }
+ });
+
showPassword.setOnCheckedChangeListener(new
CompoundButton.OnCheckedChangeListener() {
@Override
public void onCheckedChanged(CompoundButton buttonView, boolean
isChecked) {
--
To view, visit https://gerrit.wikimedia.org/r/112870
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I461696aeddef1e717c3e831b3879c804bdba0a93
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <yuvipa...@gmail.com>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
