Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/112954
Change subject: Fix positioning in TextInputMenuWidget
......................................................................
Fix positioning in TextInputMenuWidget
.position() can't be called before the parent's show(), because
we can't position something that's not visible.
Change-Id: I7f17357a445e2069caa5c7b6116ea5851e5cbf48
---
M src/widgets/OO.ui.TextInputMenuWidget.js
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/54/112954/1
diff --git a/src/widgets/OO.ui.TextInputMenuWidget.js
b/src/widgets/OO.ui.TextInputMenuWidget.js
index ddec0fa..8ef91b4 100644
--- a/src/widgets/OO.ui.TextInputMenuWidget.js
+++ b/src/widgets/OO.ui.TextInputMenuWidget.js
@@ -45,11 +45,10 @@
* @chainable
*/
OO.ui.TextInputMenuWidget.prototype.show = function () {
- this.position();
-
// Parent method
OO.ui.MenuWidget.prototype.show.call( this );
+ this.position();
this.$( this.getElementWindow() ).on( 'resize',
this.onWindowResizeHandler );
return this;
};
--
To view, visit https://gerrit.wikimedia.org/r/112954
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f17357a445e2069caa5c7b6116ea5851e5cbf48
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan.katt...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
