JGonera has uploaded a new change for review.
https://gerrit.wikimedia.org/r/113050
Change subject: Hygiene: Remove a FIXME from PhotoUploaderButton
......................................................................
Hygiene: Remove a FIXME from PhotoUploaderButton
We don't pass options anywhere, no need to extend it.
Change-Id: I349de4ffa1ccb2b7c15a020fb8f21151b10f9f98
---
M javascripts/modules/uploads/PhotoUploaderButton.js
1 file changed, 3 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/50/113050/1
diff --git a/javascripts/modules/uploads/PhotoUploaderButton.js
b/javascripts/modules/uploads/PhotoUploaderButton.js
index 63f26d2..02e7650 100644
--- a/javascripts/modules/uploads/PhotoUploaderButton.js
+++ b/javascripts/modules/uploads/PhotoUploaderButton.js
@@ -80,20 +80,15 @@
var self = this, $input = this.$( 'input' );
function handleFile( file ) {
- var options = $.extend( {}, self.options, {
- // FIXME: No need to reference parent
when new uploads move to stable
- parent: self,
- file: file
- } ),
- loadingOverlay = new LoadingOverlay();
+ var loadingOverlay = new LoadingOverlay();
loadingOverlay.show();
mw.loader.using( 'mobile.uploads', function() {
loadingOverlay.hide();
// FIXME: this is hacky but it would be
hard to pass a file in a route
- M.emit( '_upload-preview', options.file
);
- M.router.navigate( '#/upload-preview/'
+ options.funnel );
+ M.emit( '_upload-preview', file );
+ M.router.navigate( '#/upload-preview/'
+ self.options.funnel );
} );
}
--
To view, visit https://gerrit.wikimedia.org/r/113050
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I349de4ffa1ccb2b7c15a020fb8f21151b10f9f98
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
