Trevor Parscal has uploaded a new change for review.
https://gerrit.wikimedia.org/r/113069
Change subject: Removed some of the drop-shadows on buttons
......................................................................
Removed some of the drop-shadows on buttons
There were a lot of rendering inconsistencies between browsers, and it wasn't
clear that the shadows were of any value, so we just remove them and the
problem goes away.
And that's the way we achieve our goals in VisualEditor - by redefining the
meaning of success.
Change-Id: I19d33d395c9d8db59fba6fa03d87a642c9cc7c91
---
M src/styles/OO.ui.Element.css
M src/styles/OO.ui.Widget.css
2 files changed, 2 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/69/113069/1
diff --git a/src/styles/OO.ui.Element.css b/src/styles/OO.ui.Element.css
index 8373e8f..c33c00a 100644
--- a/src/styles/OO.ui.Element.css
+++ b/src/styles/OO.ui.Element.css
@@ -83,7 +83,6 @@
border-radius: 0.3em;
vertical-align: top;
text-shadow: 0 1px 1px rgba(255, 255, 255, 0.5);
- box-shadow: 0 0.1em 0.25em rgba(0, 0, 0, 0.1);
text-align: center;
/* Animation */
diff --git a/src/styles/OO.ui.Widget.css b/src/styles/OO.ui.Widget.css
index 11f258d..1537168 100644
--- a/src/styles/OO.ui.Widget.css
+++ b/src/styles/OO.ui.Widget.css
@@ -22,14 +22,12 @@
.oo-ui-buttonGroupWidget {
display: inline-block;
border-radius: 0.3em;
- box-shadow: 0 0.1em 0.25em rgba(0, 0, 0, 0.1);
}
.oo-ui-buttonGroupWidget .oo-ui-buttonedElement-framed
.oo-ui-buttonedElement-button {
border-radius: 0;
margin-bottom: -1px;
margin-left: -1px;
- box-shadow: none;
}
.oo-ui-buttonGroupWidget .oo-ui-buttonedElement-framed:first-child
.oo-ui-buttonedElement-button {
@@ -202,7 +200,7 @@
display: inline-block;
font-size: 1em;
font-family: sans-serif;
- background-color: #f7f7f7;
+ background-color: #fff;
border: solid 1px #ccc;
box-shadow: 0 0 0 white, inset 0 0.1em 0.2em #ddd;
padding: 0.5em;
@@ -230,7 +228,6 @@
outline: none;
border-color: #a7dcff;
box-shadow: 0 0 0.3em #a7dcff, 0 0 0 white;
- background-color: #fff;
}
.oo-ui-textInputWidget input[readonly],
@@ -244,6 +241,7 @@
.oo-ui-widget-disabled.oo-ui-textInputWidget textarea,
.oo-ui-widget-disabled.oo-ui-textInputWidget textarea:focus {
color: #ccc;
+ border-color: #ddd;
text-shadow: 0 1px 1px #fff;
}
@@ -331,13 +329,11 @@
.oo-ui-buttonSelectWidget {
display: inline-block;
border-radius: 0.3em;
- box-shadow: 0 0.1em 0.25em rgba(0, 0, 0, 0.1);
}
.oo-ui-buttonSelectWidget .oo-ui-buttonOptionWidget
.oo-ui-buttonedElement-button {
border-radius: 0;
margin-left: -1px;
- box-shadow: none;
}
.oo-ui-buttonSelectWidget .oo-ui-buttonOptionWidget:first-child
.oo-ui-buttonedElement-button {
--
To view, visit https://gerrit.wikimedia.org/r/113069
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I19d33d395c9d8db59fba6fa03d87a642c9cc7c91
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
