Prtksxna has uploaded a new change for review.
https://gerrit.wikimedia.org/r/113072
Change subject: [WIP] Change size of thumbnails in popup [WIP]
......................................................................
[WIP] Change size of thumbnails in popup [WIP]
Change-Id: I98ecea9d240a4400cf2277b3b393c4b024fe907f
---
M resources/ext.popups.core.js
M resources/ext.popups.core.less
2 files changed, 7 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups
refs/changes/72/113072/1
diff --git a/resources/ext.popups.core.js b/resources/ext.popups.core.js
index ebb6a1a..74d404c 100644
--- a/resources/ext.popups.core.js
+++ b/resources/ext.popups.core.js
@@ -64,9 +64,9 @@
$thumbnail = $( '<img>' )
.attr( 'src', thumbnail.source )
.removeClass(
'mwe-popups-is-tall mwe-popups-is-not-tall' )
- .addClass( tall ?
'mwe-popups-is-tall' : 'mwe-popups-is-not-tall' )
- .attr( 'width', thumbnail.width
)
- .attr( 'height',
thumbnail.height );
+ .addClass( tall ?
'mwe-popups-is-tall' : 'mwe-popups-is-not-tall' );
+// .attr( 'width', thumbnail.width
)
+// .attr( 'height',
thumbnail.height );
} else {
$thumbnail = $( '<span>' );
}
@@ -99,8 +99,8 @@
.addClass( bar.tall ? 'mwe-popups-is-tall' :
'mwe-popups-is-not-tall' )
.css({
top: offsetTop,
- left: offsetLeft,
- minHeight: bar.tall ?
bar.thumbnail.height : 'initial'
+ left: offsetLeft
+// minHeight: bar.tall ?
bar.thumbnail.height : 'initial'
})
.append( bar.box )
.show()
diff --git a/resources/ext.popups.core.less b/resources/ext.popups.core.less
index 7909138..8d0dc78 100644
--- a/resources/ext.popups.core.less
+++ b/resources/ext.popups.core.less
@@ -36,10 +36,12 @@
> img.mwe-popups-is-tall{
float: right;
+ height: 250px;
padding-left: 1.28em;
}
> img.mwe-popups-is-not-tall{
+ width: 300px;
float: initial;
}
--
To view, visit https://gerrit.wikimedia.org/r/113072
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I98ecea9d240a4400cf2277b3b393c4b024fe907f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
